-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MIDI Fighter Twister controller #1778
Conversation
Hi, thanks for submitting this. I apologize for not responding for a long time. We require documentation on the wiki before merging controller mappings; otherwise it tends to not get written. From the picture posted here, I suggest switching the positions of the BPM and gain knobs because it's conventional on DJ controllers and mixers to have the channel gain knobs at the top of the EQs. Please use the Otherwise, the code looks neat and tidy. Good job 👍 It would be great to map this controller for Mixxx's effects too. This controller has a very similar layout to the Allen & Heath Xone K2 and could be mapped similarly. You may be able to reuse code from the Xone K2 mapping. If you're not interested in working on that, that's okay, it will still be good to have this simple 2 deck mapping. |
Does this work with the default out-of-the-box MIDI settings for the MIDI Fighter Twister or would a user need to load a configuration with the MIDI Fighter settings program? It would be better to use the out-of-the-box MIDI settings because the MIDI Fighter settings program is not available on Linux. I have asked DJTechTools about configuring the settings via MIDI, but that's currently not supported. |
Thanks for the response.
Thanks for the suggestion but I almost never use effects so I leave that job for someone more motivated than me 😣
Yes
Yeah I don't have Windows so very frustrated by that 😫 |
Thank you for the update. I realized the volume faders and PFL buttons are not in this mapping, only the crossfader. I think it would be helpful to use the unmapped knobs for these, with pushing them being used for the PFL button. |
That's right. I did it. |
@@ -169,6 +169,26 @@ | |||
<normal/> | |||
</options> | |||
</control> | |||
<control> | |||
<group>[Channel1]</group> | |||
<key>volume</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no MIDI output for these? Or did you forget to add changes to the JS file to your commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I forgot it c219a6a
}), | ||
engine.makeConnection("[Channel2]", "volume", function(value) { | ||
midi.sendShortMsg(cc, 0x0B, linearize(value) * 2); | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the PFL button? I think the LED below the volume knob should show the state of that.
Great, thank you. Could you rebase this on the 2.1 branch so we can include it in the upcoming 2.1.5 release? |
👍 |
First of all, thanks for awesome project!
MIDI Fighter Twister is a MIDI controller which have 16 push-able knobs with LED.
I made a config for 2 deck use.
This config does:
I'll write wiki page later.