Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropping from finder Lp1822424 #2068

Merged
merged 6 commits into from
Apr 6, 2019
Merged

Conversation

daschuer
Copy link
Member

https://bugs.launchpad.net/mixxx/+bug/1822424

This is essentially a backport of
qt/qtbase@be5cfa9

It converts a reference file URL to a file path Url using objective C

@daschuer
Copy link
Member Author

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSString", referenced from:
      objc-class-ref in filepathurl.o
  "_objc_msgSend", referenced from:
      stringFromNSString(NSString const*) in filepathurl.o
      urlFromNSURL(NSURL const*) in filepathurl.o
      ensureFilePathUrl(QUrl const&) in filepathurl.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I guess I am missing a linker command.
Who knows how to solve this?

@ferranpujolcamins
Copy link
Contributor

This patch fixes the build for me.
addFoundation.patch.zip

@ferranpujolcamins
Copy link
Contributor

And I can confirm this fixes the drag and drop issue both for library tracks and new tracks.

@daschuer
Copy link
Member Author

daschuer commented Apr 1, 2019

All green :-) Thank you.
Can we merge this and finally release 2.1.8?

@daschuer daschuer added this to the 2.1.x milestone Apr 1, 2019
@daschuer
Copy link
Member Author

daschuer commented Apr 2, 2019

@ferranpujolcamins or @uklotzde: Can you have a look? I want to release 2.1.8 including this soon.

build/depends.py Outdated
@@ -23,6 +23,17 @@ def configure(self, build, conf):

def sources(self, build):
return ['soundio/sounddeviceportaudio.cpp']


class FilePathURL(Dependence):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"FilePathURL" is a very generic name for a platform-specific and version-dependent workaround. How about renaming this to "OSXFilePathUrl" or "OSXFilePathUrlBackport"?

#import <Foundation/Foundation.h>


// Taken from src/platformsupport/clipboard/qmacmime.mm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reference of the Qt version from which this has been copied/backported might be helpful. The plain path even doesn't reveal that this is actually source code from Qt. Please use an URL.

@daschuer
Copy link
Member Author

daschuer commented Apr 3, 2019

Done

@uklotzde
Copy link
Contributor

uklotzde commented Apr 6, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants