-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropping from finder Lp1822424 #2068
Conversation
I guess I am missing a linker command. |
This patch fixes the build for me. |
And I can confirm this fixes the drag and drop issue both for library tracks and new tracks. |
All green :-) Thank you. |
@ferranpujolcamins or @uklotzde: Can you have a look? I want to release 2.1.8 including this soon. |
build/depends.py
Outdated
@@ -23,6 +23,17 @@ def configure(self, build, conf): | |||
|
|||
def sources(self, build): | |||
return ['soundio/sounddeviceportaudio.cpp'] | |||
|
|||
|
|||
class FilePathURL(Dependence): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"FilePathURL" is a very generic name for a platform-specific and version-dependent workaround. How about renaming this to "OSXFilePathUrl" or "OSXFilePathUrlBackport"?
src/util/filepathurl.mm
Outdated
#import <Foundation/Foundation.h> | ||
|
||
|
||
// Taken from src/platformsupport/clipboard/qmacmime.mm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reference of the Qt version from which this has been copied/backported might be helpful. The plain path even doesn't reveal that this is actually source code from Qt. Please use an URL.
Done |
LGTM |
https://bugs.launchpad.net/mixxx/+bug/1822424
This is essentially a backport of
qt/qtbase@be5cfa9
It converts a reference file URL to a file path Url using objective C