-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render duration of intro & outro ranges on overview waveforms #2089
Conversation
MarkRange elements in skins only have their durations rendered if they specify a DurationTextColor. This avoids rendering the durations of loops on the overview waveform.
Very helpful feature 👍 Instead of only enabling/disabling the display we could think about specifying a minimum duration, e.g. with a configurable range between 0 to 30 seconds and a default value of 3 or 5 seconds -> Checkox + Slider. This value may vary depending on your music and mixing style. Not sure if this is more confusing than helpful? Now I also noticed that I need minute markers on the overview waveforms for a quick peek how long a phrase might be 🙈 |
I think that would be more confusing than helpful. |
Why do you want the text moved outside the range? And why move it to the top? If we can find a solution that everyone is satisfied with that does not require a preference option that would be ideal. |
It look IMHO ugly if the time labele escapes the boundaries of the highlighted region. |
To clarify, are you proposing putting the text outside the range on the side closer to the middle of the track? So for the intro it would be drawn after the range and for the outro it would be drawn before the range? |
This is exactly how I understood Daniel's proposal. The labels would be displayed outside of the (probably short region) within the main track range, next to their nearest marker. For short intro/outro ranges the labels might not fit entirely into their sections and would otherwise be displayed across the boundaries with varying backgrounds. There is no ideal solution. With Daniel's proposal the appearance is slightly more consistent. |
Yes, as an idea for discussion. The part I like most is the idea to have the texts and the triangle close to each other and not draw across the region borders. |
This avoids the text overlapping the borders of the range, which looks ugly.
to match all the other skins
This saves a little space, which is helpful for the duration text for intro/outro sections on the overview waveforms.
Ok, thank you. |
LGTM Thanks, waiting for CI. |
CI passed 👍 |
If there is still a demand for adding an option to disable this, that can still be added during the 2.3 beta period. Hopefully this looks good enough that it isn't bothersome enough to anyone that an option is required. |
MarkRange elements in skins only have their durations rendered if they specify a DurationTextColor. This avoids rendering the durations of loops on the overview waveform.
durations scale with rate slider:
I played a 3 hour set with this last night and it is extremely helpful for me. Having Mixxx calculate these times for me allows me to be more intentional about how I align tracks. I used to do this in headphones continually. With this I don't have to keep the times in my head, I don't have to do any math, and I don't have to repeat that the next time I play a track.
I understand this could be distracting or clutter for others, so I'll add an option to disable this unless there are objections to adding an option.