lp1828212: Fix missing key analysis #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thank you for the quick fix! |
daschuer
reviewed
May 9, 2019
|
@Be-ing Are you able to verify by ear that the previous not detected track has now the right value using a piano or a compatible track. Else you may look at the Fft spectrum in audacity. The peak frequencies should match the detected keys chord. |
|
@daschuer I have no idea how those crappy QM plugins work. Please feel free to fix the workaround if needed ;) |
|
Ok, I can have a look. Do you have an idea why only master is effected? |
|
The bug was introduced when VAMP plugins were removed in #926, so that is why only master is affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1828212
The code comments document why and how.