reduce number of sent midi messages for wheel leds #2326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem that the rate that midi messages are sent to the controller apparently exceeds the maximum when the audio buffer size is set lower than 10ms. It was caused by the "playposition" control that in the ddj-sx controller script updates the position of the wheel leds inside the jog wheel. Apparently, when the buffer size is reduced, the number of position updates increases.
What happens than can be seen in the following video. All controls react in a delayed behavior as soon as two decks are playing and updating the wheel leds.
https://projects.goddi.ddnss.eu/wp-content/uploads/delayed_behavior.mkv
Therefore, I adapted the DDJ-SX script such that a midi message is only sent when the position of the wheel leds is really changed. Thanks to @JosepMaJAZ who pointed me towards the cause of the problem and the solution.