Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of sent midi messages for wheel leds #2326

Merged
merged 1 commit into from
Oct 19, 2019
Merged

reduce number of sent midi messages for wheel leds #2326

merged 1 commit into from
Oct 19, 2019

Conversation

goddisignz
Copy link
Contributor

I had the problem that the rate that midi messages are sent to the controller apparently exceeds the maximum when the audio buffer size is set lower than 10ms. It was caused by the "playposition" control that in the ddj-sx controller script updates the position of the wheel leds inside the jog wheel. Apparently, when the buffer size is reduced, the number of position updates increases.

What happens than can be seen in the following video. All controls react in a delayed behavior as soon as two decks are playing and updating the wheel leds.
https://projects.goddi.ddnss.eu/wp-content/uploads/delayed_behavior.mkv

Therefore, I adapted the DDJ-SX script such that a midi message is only sent when the position of the wheel leds is really changed. Thanks to @JosepMaJAZ who pointed me towards the cause of the problem and the solution.

@Be-ing Be-ing changed the base branch from master to 2.2 October 19, 2019 13:43
@Be-ing
Copy link
Contributor

Be-ing commented Oct 19, 2019

Again, please rebase this on the 2.2 branch.

@goddisignz
Copy link
Contributor Author

Oh sorry, I didn't get your comment the first time. I was just confused where all these commits come from and thought I just made a mistake in the PR. Will do.

@Holzhaus
Copy link
Member

Holzhaus commented Oct 19, 2019

@goddisignz In case you're not fluent in git, just do the following:

# First add the "upstream" remote and make sure you have the latest state of it
$ git remote add upstream https://github.com/mixxxdj/mixxx.git
$ git fetch upstream
# Then rebase on the "2.2" branch
$ git rebase -i upstream/2.2

The last command will open an editor window which shows all commits since 2.2. Delete all lines that do not belong to your PR. Basically, keep only the line that says pick ae98a4b reduce number of sent midi messages for wheel leds. If you're using vim, just type :%g!/ae98a4b/d to delete all lines not containing the string ae98a4b, hit enter and save and exit the file using :wq. Then force-push your branch:

$ git push -f origin ddj-sx-reduce-messages

@goddisignz
Copy link
Contributor Author

Thanks @Holzhaus. I did rebasing before but never to a different branch.

@Be-ing Be-ing merged commit 70e7ce9 into mixxxdj:2.2 Oct 19, 2019
@Be-ing
Copy link
Contributor

Be-ing commented Oct 19, 2019

Thank you!

@goddisignz goddisignz deleted the ddj-sx-reduce-messages branch October 20, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants