Add extra_metadata flag #2418
Closed
Add extra_metadata flag #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still thinking about how to achieve this without exposing a new, public feature flag that doesn't have an actual use case, yet. It might be confusing. If we decide to do it this feature flag should not only be declared as experimental but also as internal to prevent repo maintainers from enabling it! |
|
Until then #2282 is continuously built and tested with |
|
Ok, if you think this is not necessary I'll close this for now. |
|
We might have an actual use case soon: https://github.com/uklotzde/mixxx/tree/acoustidclient2 |
|
...addressing https://bugs.launchpad.net/mixxx/+bug/1581256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional build flag and enable it for CI builds to ensure that there are no build-time errors in @uklotzde's metadata code.