Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Connect/disconnect BaseTrackCache in TrackCollection #2513

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Hotfix: Connect/disconnect BaseTrackCache in TrackCollection #2513

merged 2 commits into from
Feb 23, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Feb 23, 2020 •
edited
Loading

Crash on exit

disconnect() was called on the wrong object and with the wrong argument. I have moved all operations into TrackCollection where they belong to avoid further confusion.

@uklotzde uklotzde mentioned this pull request Feb 23, 2020
Merged
@uklotzde uklotzde requested a review from daschuer February 23, 2020 00:51
@daschuer
Copy link
Member

Oh sorry I did not test this last minute commit either. LGTM.

@daschuer daschuer merged commit 642f216 into mixxxdj:master Feb 23, 2020
@uklotzde
Copy link
Contributor Author

uklotzde commented Feb 23, 2020 •
edited
Loading

@daschuer Only happened if modified tracks in GlobalTrackCache needed to be saved. I didn't notice either although I should have even more.

@uklotzde uklotzde deleted the disconnect_hotfix branch February 24, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer Awaiting requested review from daschuer

Assignees
No one assigned
Labels
critical bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer