Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the "Reload from Musicbrainz" option in the context menu and opti... #27

Merged
merged 1 commit into from
Jun 28, 2013
Merged

Rename the "Reload from Musicbrainz" option in the context menu and opti... #27

merged 1 commit into from
Jun 28, 2013

Conversation

esbrandt
Copy link
Contributor

...mize MB dialog, https://bugs.launchpad.net/mixxx/+bug/1184157

  • Add separator in the context menu to group metadata related menu points
  • Rename available options to "Reload Metadata from File" and "Get Metadata from MusicBrainz"
    Since all options in this menu are somehow related to a track, it was reasonable to drop the extra "track" from
    both menu points.
  • In the MusicBrainz fetcher dialog:
    • Add descriptive Title to the dialog window
    • Add some translator comments
    • Change Song -> Track
    • Change button order to be like in the Tracks Properties dialog
    • Use Ampersands (&) for button text to quickly access that particular GUI element.
    • Fix tab order.
    • Removes styling for some text in error messages. We already have different styles in the preferences dialogs (which is bad and needs clean up), go with the system default instead.
  • In the Tracks Properties dialog, metadata buttons are now in the same order like in the context menu. Also fix tab order.

@rryan
Copy link
Member

rryan commented Jun 28, 2013

LGTM -- thanks!

rryan added a commit that referenced this pull request Jun 28, 2013
@rryan
Merge pull request #27 from esbrandt/lp1184157
f5ce1e4 
Rename the "Reload from Musicbrainz" option in the context menu and opti...
@rryan rryan merged commit f5ce1e4 into mixxxdj:master Jun 28, 2013
@ywwg ywwg mentioned this pull request Dec 20, 2013
Merged
@daschuer daschuer mentioned this pull request Dec 28, 2014
Merged
@esbrandt esbrandt deleted the lp1184157 branch January 27, 2018 14:29
ronso0 referenced this pull request in ronso0/mixxx Jan 29, 2018
@daschuer
Merge pull request #27 from nopeppermint/patch-2
f0b6a0c 
better contrast in color shemes
@daschuer daschuer mentioned this pull request Jun 11, 2018
Closed
11 tasks
ronso0 referenced this pull request in ronso0/mixxx Oct 15, 2019
@Be-ing
Merge pull request #27 from ronso0/hotcue-label-fixes
e2407e5 
Hotcue label fixes
@uklotzde uklotzde mentioned this pull request Jan 16, 2020
Merged
Holzhaus pushed a commit to Holzhaus/mixxx that referenced this pull request Aug 23, 2020
@esbrandt
Add info on multi column sorting option in library, fixes mixxxdj#27
6bb22f0
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Aug 3, 2022
@Swiftb0y
refactor(enginebuffer): Make EngineBuffer::KeylockEngine an enum class (
d92a6bf 
mixxxdj#27)

refactor(prefs): improve keylockengine-related typesafety
@mixxxbot mixxxbot mentioned this pull request Aug 22, 2022
Closed
@ronso0 ronso0 mentioned this pull request Sep 4, 2022
Merged
@ronso0 ronso0 mentioned this pull request May 9, 2023
Merged
@Swiftb0y Swiftb0y mentioned this pull request Aug 7, 2023
Closed
m0dB pushed a commit to m0dB/mixxx that referenced this pull request Jan 21, 2024
@rryan
Merge pull request mixxxdj#27 from Be-ing/change_title
5e4ecdb 
change front page title to reflect data from search terms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esbrandt @rryan