Rekordbox save all loops and correct AAC timing offset for CoreAudio #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
reviewed
May 11, 2020
Be-ing
reviewed
May 11, 2020
Be-ing
reviewed
May 11, 2020
Be-ing
reviewed
May 11, 2020
Be-ing
reviewed
May 11, 2020
Be-ing
reviewed
May 12, 2020
Be-ing
reviewed
May 12, 2020
Be-ing
reviewed
May 12, 2020
Be-ing
reviewed
May 12, 2020
Be-ing
reviewed
May 12, 2020
Be-ing
reviewed
May 12, 2020
|
Whoops this was targeted at master... |
|
I rebased this on 2.3 and added a commit to break some of the long lines (c6b66bb). Thank you for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save all Rekordbox loops as hotcues, as requested here: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Rekordbox.20loop.20numbers/near/196713410
In implementing this found memory cue and loop colors were incorrect, which is now fixed.
Also added correct timing offset for AAC files when using CoreAudio sound source (no offset required for FAAD2 or FFmpeg).