-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update database help message #2979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This generally LGTM, but I'm unsure if it makes sense to update the TS files as these are pull edfrom Transifex anyway IIRC.
Ah ok, I wasn't involved in the translation yet. |
Those files are generated by Transifex. Modifying them locally is pointless. |
@xerus2000 Can you run |
But how are the strings updated then? I don't see a need to retranslate it in all languages. |
What's the reason for 2f5be78 Reorder schema update function signature? |
It is much more likely that you want to specify a different target schema version rather than a different schema file. Since you don't seem to like to have separate PRs for such things, I thought it would fit in here. |
This is just an assumption and guessing. Don't change existing code without any actual requirements. |
@@ -1,10 +1,7 @@ | |||
#ifndef TRACKID_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid to include unrelated changes in future PRs.
LGTM |
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Users are still pointed to some ancient mailing list no-one uses anymore.
I changed "contact" to "consult" rather than "see" because it is reasonably general and thus allows us to point to almost anything without having to change the wording again.