Cachingreader fix2 "dedicated thread for CachingReaderWorker" #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hintList) according to code style guide
| Q_ASSERT(memory_to_use >= kChunkLength); | ||
|
|
||
| // Only allocate as many bytes as we will actually use. | ||
| memory_to_use -= (memory_to_use % kChunkLength); |
There was a problem hiding this comment.
memory_to_use is unused since the worker doesn't allocate the chunks
|
This looks good -- the engine callback doesn't touch the QSemaphore at all (which is good because both release/acquire can block) and the scheduling happens after the callback. Thanks! |
Conflicts: src/soundsourcemp3.cpp
|
@rryan: Thank you for review |
daschuer
added a commit
that referenced
this pull request
Jul 3, 2013
Cachingreader fix2 "dedicated thread for CachingReaderWorker"
Merged
11 tasks
ronso0
referenced
this pull request
in ronso0/mixxx
Oct 24, 2019
Use Cue::kPositionNotDefined for unset cue positions.
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
add subsection for installing presets from the forum
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Wiki archive: exclude unneeded directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the race condition when loading a track.
I could be interesting to measure the performance difference from the original version, but I don't know how.