Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for rlimits on Linux #31

Merged
merged 2 commits into from
Jul 3, 2013
Merged

check for rlimits on Linux #31

merged 2 commits into from
Jul 3, 2013

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jul 2, 2013

Gives a hint in sound preferences if the Limits are not set.

rryan
rryan reviewed Jul 2, 2013
View reviewed changes
src/util/rlimit.cpp
@@ -0,0 +1,35 @@
#include "rlimit.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the absolute path:
#include "util/rlimit.h"

@rryan
Copy link
Member

rryan commented Jul 2, 2013

Other than the minor comments, LGTM

@esbrandt
Copy link
Contributor

esbrandt commented Jul 3, 2013

Imo we can leave out translator comments here, because dealing with small HTML blobs like links or %1 variables are explained in the glossary as well as the translator pages, see http://mixxx.org/wiki/doku.php/internationalization . OTOH I would suggest to delete the <ul> tags ,also for the other bullet points in the latency tips. If we`d move them to separate rows in a horizontal layout, each line is presented as separate string in the translation interface.

@daschuer
Copy link
Member Author

daschuer commented Jul 3, 2013

I am in favor not to change the lines above, because they are already translated. If we try to make them more easy to translate by changing them we will in fact force the translators to translate them again.

daschuer added a commit that referenced this pull request Jul 3, 2013
@daschuer
Merge pull request #31 from daschuer/limits
9f1d25e 
check for rlimits on Linux
@daschuer daschuer merged commit 9f1d25e into mixxxdj:master Jul 3, 2013
@esbrandt
Copy link
Contributor

If the check is performed on Linux only, isn't it redundant to display the hint in sound preferences on Mac ( and probably Windows)?
about mixxx

@daschuer
Copy link
Member Author

This should be only displayed in the Linux version. I will prepare a fix.

@daschuer
Copy link
Member Author

Fixed in r3520 3069596

@ywwg ywwg mentioned this pull request Dec 20, 2013
Merged
@daschuer daschuer mentioned this pull request Dec 28, 2014
Merged
daschuer added a commit that referenced this pull request Apr 5, 2018
@daschuer
Merge pull request #31 from Be-ing/2.1_rc1
f85d21b 
2.1 RC1 CHANGELOG updates
@daschuer daschuer mentioned this pull request Jun 11, 2018
Closed
11 tasks
Swiftb0y pushed a commit to Swiftb0y/mixxx that referenced this pull request Nov 3, 2019
@Be-ing
Merge pull request mixxxdj#31 from daschuer/autodj_intro_outro
7daa180 
Autodj Edge cases.
Holzhaus pushed a commit to Holzhaus/mixxx that referenced this pull request Aug 23, 2020
@kain88-de
Merge pull request mixxxdj#31 from Be-ing/introduction
b39ec56 
Introduction revisions
@ronso0 ronso0 mentioned this pull request Sep 4, 2022
Merged
@ronso0 ronso0 mentioned this pull request May 9, 2023
Merged
@Swiftb0y Swiftb0y mentioned this pull request Aug 7, 2023
Closed
m0dB pushed a commit to m0dB/mixxx that referenced this pull request Jan 21, 2024
@Be-ing
Merge pull request mixxxdj#31 from daschuer/2.1.1
903170f 
Change download to  2.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @rryan @esbrandt