Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Engine Prime with libdjinterop on MacOS CI #3102

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

mr-smidge
Copy link
Contributor

The MacOS CI builds were not previously able to enable the ENGINEPRIME feature, as the older compiler in this environment couldn't cope with <optional>. This PR bumps the version of libdjinterop up to 0.13.0, which adds a workaround for compilers that only have <experimental/optional>.

Aside: the version bump is also useful for separate PR #2753, which can make use of newer functionality.

@uklotzde uklotzde marked this pull request as ready for review September 17, 2020 06:26
@uklotzde
Copy link
Contributor

It works 👍 LGTM

@uklotzde uklotzde merged commit e8e7877 into mixxxdj:master Sep 17, 2020
@mr-smidge
Copy link
Contributor Author

Awesome, thanks Uwe 😄.

@poelzi poelzi mentioned this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants