Nix updates 2.3 #3258

poelzi · 2020-11-03T01:40:03Z

These is a backport of #3174 to 2.3.

It fixes all issues I found so far in the derivate.
This will allow us to deliver up to date derivates through cachix to the enduser.
This branch now has working travis for nix and runs all tests.

poelzi · 2020-11-06T02:18:58Z

@haslersn wanna review ?
I'm using this version now for quite some time and it works very nicely. I added nix ci that run the tests and will publish to cachix.
This way you will be able to test a branch without compiling :)

I would like to have this in 2.3 soon, so we can official builds.

* Fixes lv2 wrapper so plugins show up again * Remove old binaries so makeWrapper does not create useless backups * Autodetect cmake buildtype and set type * Fix locale problems on none nix hosts * Remove useless imports and use "with" where possible * format sources with nixfmt * ingnore result* for sources * Allow cmake flags to be passed * wrap mixxx-test for running in ci environment * set QT_PLUGIN_PATH in case we run tests in a CI without proper paths

push packages to cachix Correctly report error codes. Run tests in travis dev shell don't fail if cache copy fails

Including the setup hook script does not work and only causes problems. Simply use nix-shell to run the wrapper in a reliable way. Add nodjs for eslint

Inform the user that this combination might break and how to mitigate it.

LLVM < 10.0.2 with glibc >= 2.31 don't link well with fast-math active. Add option to disable this optimization alone

Holzhaus · 2021-05-13T14:58:34Z

Just for my understanding: Why do we need to pull the NixOS artifacts into the Mixxx source repo and extend our CI builds instead of hosting the configuration files in nixpkgs? There is even a dedicated build system for NixOS packages.

I think nixpgs is for stable packages, but this config is for development versions and building from source. I think https://github.com/nix-community/NUR would be the proper repo for that.

Holzhaus · 2021-05-15T12:52:21Z

How do we continue here? We shouldn't tag 2.3.0 with a broken nixOS config. I think we have 4 alternatives:

Merge this PR including CI builds
Merge this PR excluding CI builds
Merge Fixes for shell.nix #3795 instead of this PR
Merge neither and remove the nixOS config from our source tree

Opinions?

JoergAtGithub · 2021-05-15T13:04:38Z

I'm in favour of #1, because the CI build with Clang compiler ensures compatibility, not only for NIX.

Holzhaus · 2021-05-15T13:06:16Z

I'm in favour of #1, because the CI build with Clang compiler ensures compatibility, not only for NIX.

We already ensure clang compatibility with the clang-tidy, clazy and macOS CI builds.

uklotzde · 2021-05-15T13:08:40Z

The CI builds are not needed. NixOS users will notice any breakage when building locally and could then file a PR. Why should we maintain CI builds that affect only very few users, are unmaintainable for most of us, and are not needed for any official release? We also don't host CI builds for other Linux distributions.

uklotzde · 2021-05-15T13:11:21Z

I'm in favour of #1, because the CI build with Clang compiler ensures compatibility, not only for NIX.

We already ensure clang compatibility with the clang-tidy, clazy and macOS CI builds.

Correct, we already have one CI build for each compiler suite (GCC, Clang, MSVC). We cannot test all possible combinations including different versions, platforms, CPU architectures, ...

Holzhaus · 2021-05-15T13:14:42Z

I'd prefer 4, but I'm also okay with 3 or 2 if most others disagree. If we chose 1, all PRs with failing nixOS builds are essentially blocked until @poelzi reviews them and contributes a fix. Or we ignore if the nixOS CI fails, which makes them kinda pointless.

daschuer · 2021-05-15T20:09:26Z

I vote for 2 or 3. If we decide for 2, I would prefer to cut out unrelated changes into single PRs.

See related discussions here: - https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/2.2E3.20planning.3A.20https.3A.2F.2Fgithub.2Ecom.2Fmixxxdj.2Fmixxx.2Fprojects.2F2/near/239494309 - mixxxdj#3258 (comment)

…es-2.3

github-actions · 2021-12-07T00:34:11Z

This PR is marked as stale because it has been open 90 days with no activity.

daschuer · 2022-01-18T08:50:00Z

Can we close this stale PR now? Our main build tool is cmake and we don't have the power to maintain another build script of 397 lines.
See the discussion in #3795 (comment) for the option striping it down to an environment setup only tool.

github-actions · 2022-04-20T00:08:15Z

This PR is marked as stale because it has been open 90 days with no activity.

cr7pt0gr4ph7 · 2024-06-07T15:27:06Z

Currently going through old & stale PRs in an effort to reduce the number of open PRs.
I'd argue that if this build script update wasn't relevant two years ago, it very much isn't relevant now, and can be closed.

daschuer · 2024-06-07T15:42:10Z

Yes, let's close this and than also decide for
#3795
as well.

cr7pt0gr4ph7 · 2024-06-07T15:49:41Z

Yes, let's close this and than also decide for #3795 as well.

#4632 would also be a candidate for closing then.

github-actions bot added the build label Nov 3, 2020

poelzi force-pushed the nix-updates-2.3 branch 2 times, most recently from 8d798cd to bb5991f Compare November 14, 2020 04:26

ronso0 added this to the 2.3.0 milestone Nov 16, 2020

poelzi force-pushed the nix-updates-2.3 branch 3 times, most recently from 19ceb4d to 8e636ef Compare November 24, 2020 18:36

poelzi and others added 20 commits November 24, 2020 21:36

Enable nix derivates on travis

6c2b940

push packages to cachix Correctly report error codes. Run tests in travis dev shell don't fail if cache copy fails

Change to Build directory before copying cache

598ee75

Add colored output if no QT_MESSAGE_PATTERN is set

8eea270

Add cachix signing key to .travis.yml.

21efdea

Fix wrong wrapper searchpath

886d866

add srom / pre-commit dependency

d0c4489

Use system pre-commit if version is gt 2.0

8af1682

Add workaround for wrapQtApp wrapper invocation

e4326d5

Including the setup hook script does not work and only causes problems. Simply use nix-shell to run the wrapper in a reliable way. Add nodjs for eslint

Add nixfmt in development shell

a03366d

Add faad & nix to dependencies

76143b4

fix faad loading path

5f069f0

Warn user on older llvm versions about optimization

5cbd7d7

Inform the user that this combination might break and how to mitigate it.

Add support for clang & clazy

848f539

simplify travis

1822cb3

Use CI clazy parameters if not set

983b137

Add workaround for fast-math bugs

dedf8aa

LLVM < 10.0.2 with glibc >= 2.31 don't link well with fast-math active. Add option to disable this optimization alone

Use Github Actions for nix dev build

b639b22

add caching to github actions nix dev build

f1a6258

cache nix packages

7033752

Holzhaus mentioned this pull request May 19, 2021

nixOS: Remove broken default.nix file #3881

Merged

uklotzde modified the milestones: 2.3.0, 2.3.1 May 19, 2021

poelzi added 3 commits June 28, 2021 12:04

fix empty lv2 plugin list

7c1045f

fix build with 21.05

69a5a8b

Merge branch '2.3' of https://github.com/mixxxdj/mixxx into nix-updat…

d339e2a

…es-2.3

uklotzde modified the milestones: 2.3.1, 2.3.2 Sep 7, 2021

poelzi mentioned this pull request Sep 14, 2021

vcpkg manifest mode #4281

Closed

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Dec 7, 2021

daschuer removed this from the 2.3.2 milestone Jan 15, 2022

poelzi mentioned this pull request Jan 17, 2022

Revert "Write _version.h from CMakeList.txt to remove redundant Mixxx… #4630

Closed

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Jan 19, 2022

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Apr 20, 2022

daschuer closed this Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nix updates 2.3 #3258

Nix updates 2.3 #3258

poelzi commented Nov 3, 2020

poelzi commented Nov 6, 2020 •

edited

Loading

Holzhaus commented May 13, 2021 •

edited

Loading

Holzhaus commented May 15, 2021

JoergAtGithub commented May 15, 2021

Holzhaus commented May 15, 2021 •

edited

Loading

uklotzde commented May 15, 2021

uklotzde commented May 15, 2021

Holzhaus commented May 15, 2021 •

edited

Loading

daschuer commented May 15, 2021

github-actions bot commented Dec 7, 2021

daschuer commented Jan 18, 2022

github-actions bot commented Apr 20, 2022

cr7pt0gr4ph7 commented Jun 7, 2024

daschuer commented Jun 7, 2024

cr7pt0gr4ph7 commented Jun 7, 2024

Nix updates 2.3 #3258

Nix updates 2.3 #3258

Conversation

poelzi commented Nov 3, 2020

poelzi commented Nov 6, 2020 • edited Loading

Holzhaus commented May 13, 2021 • edited Loading

Holzhaus commented May 15, 2021

JoergAtGithub commented May 15, 2021

Holzhaus commented May 15, 2021 • edited Loading

uklotzde commented May 15, 2021

uklotzde commented May 15, 2021

Holzhaus commented May 15, 2021 • edited Loading

daschuer commented May 15, 2021

github-actions bot commented Dec 7, 2021

daschuer commented Jan 18, 2022

github-actions bot commented Apr 20, 2022

cr7pt0gr4ph7 commented Jun 7, 2024

daschuer commented Jun 7, 2024

cr7pt0gr4ph7 commented Jun 7, 2024

poelzi commented Nov 6, 2020 •

edited

Loading

Holzhaus commented May 13, 2021 •

edited

Loading

Holzhaus commented May 15, 2021 •

edited

Loading

Holzhaus commented May 15, 2021 •

edited

Loading