Improved VinylControlXwax::establishQuality #3279

JoergAtGithub · 2020-11-09T21:21:02Z

I changed the implementation of VinylControlXwax::establishQuality that it doesn't only consider the position codes, but also the pitch information. This provides control signal quality information also in case of slow spinning control vinyls like cueing (but not in case of heavy scratching).
The intention is to use the control signal quality in follow up PRs as input for other logic, where I need to get a reliable information in short time (e.g. disable the Passthrough-Button, if a control vinyl is on the deck).
The new implementation allowed it to reduce the size of the quality ring buffer from 100 to 32. Which reduces response time and calculation effort.
Currently this information is only used for the color of the vinyl control scope.

src/vinylcontrol/vinylcontrolxwax.cpp

Be-ing · 2020-12-08T08:05:42Z

Can you rebase this on main to get GitHub Actions to make a Windows build? I could then test this on my friend's timecode setup, although I'm not sure when I'll next get a chance to do so.

… pitch information additional to the position code. This results in faster response and the function provides also quality information at slow rotation

…atements

JoergAtGithub · 2021-01-16T19:35:21Z

@ywwg Do you intend to review this?

ywwg · 2021-01-20T17:49:45Z

I'll try to take a look, but don't block on me. (Note that the PR reports conflicts)

Holzhaus · 2021-01-20T18:48:29Z

@mixxxdj/developers Has anyone else have DVS setup to test this with?

I do have timecode vinyl but didn't look into affordable SL-1210 yet, just a consumer record player from the 80s that I only use for listening to my Jazz collection.

ywwg

thanks for helping improve this old code!

ywwg · 2021-02-13T16:27:13Z

src/vinylcontrol/vinylcontrolxwax.cpp

+        // Position code changed not by more than 5. This indicates a normal spinning conrol vinyl.
+        positionQualityPercent = 100;
+    } else {
+        // Position code changed by more than 5. This indicates a fast spinning control vinyl, a jumping needle or a false signal.


what if we use a simple calculation that gradually reduces the qualitypercent as the velocity increases? Rather than a three-step threshold.

I don't see, how this can be expressed by a linear expression:

Position code -1 is a special case which needs to be handled

+-5 codes difference happen in normal operation due to the sample rate of the quality information. If the vinyl spins a bit faster than 100% nominal speed, it's still a good signal, but we will have missing position codes.

Higher code differences, are either a extreme fast spinning vinyls, a jumping needle or a weak signal.

ywwg · 2021-02-13T16:27:53Z

src/vinylcontrol/vinylcontrolxwax.cpp

+        if (pitchStability < 3.0) {
+            // Unlikely that this pitch difference is from a proper set up control vinyl
+            pitchQualityPercent = 0;
+        } else if (pitchStability > 6.0) {


again can you represent this set of thresholds with a simple linear equation?

(1 + tanh( pitchstability + 3 ) ) * 50 could work.
But this would require much more calculation effort, in this often executed real time code, than the two comparisations.
Do you think it's worth it?

src/vinylcontrol/vinylcontrolxwax.cpp

Holzhaus · 2021-04-02T12:57:33Z

Ping @ywwg. I don't have a DVS setup to test this with.

Holzhaus · 2021-05-05T12:27:55Z

@ywwg What's the status of this? Do you agree with @JoergAtGithub's replies to your review comments? Is there more to be done?

ywwg · 2021-05-30T04:56:09Z

Sorry for the lack of update. I'll try to take a look at this soon

github-actions · 2021-08-29T00:30:11Z

This PR is marked as stale because it has been open 90 days with no activity.

Be-ing · 2021-08-29T00:30:38Z

ping @ywwg

Holzhaus · 2021-08-29T01:43:14Z

ping @ywwg

Maybe ping him on Zulip, I think he mentioned that he doesn't always see the notifications on GH.

ywwg

I'm really sorry for the incredible delay on this. This is good and fine overall, but I do see the following output on the console: warning [Main] QColor::setHsv: HSV parameters out of range. This seems to happen when the quality is low. Double check in wspinny.cpp that we aren't passing crazy values to qual_color.setHsv

ywwg · 2021-11-26T15:37:31Z

src/vinylcontrol/vinylcontrolxwax.cpp

+
+void VinylControlXwax::establishQuality(double& pitch) {
+    m_iQualityRing[m_iQualityRingIndex] = getPositionQuality() + getPitchQuality(pitch);
+    m_fTimecodeQuality =


Github isn't letting me do a multiline suggestion, but this should be:

m_fTimecodeQuality = std::max<float>(0.0, std::min<float>(1.0, static_cast<float>(std::accumulate( m_iQualityRing, m_iQualityRing + m_iQualityRingFilled, 0)) / 2.0f / 100.0f / static_cast<float>(m_iQualityRingFilled))); // Two information in percent per datapoint

clamp the value from 0 to 1 to prevent the HSV warnings I noted below

or actually, we have a math_clamp that can do it

@JoergAtGithub if you're no longer around I'll open a duplicate PR that preserves your commits, and add this one change -- sorry again for the delay.

@ywwg This is done!

…hpitch

ywwg

lgtm

JoergAtGithub · 2021-12-15T22:07:59Z

Thanks for the review!

JoergAtGithub force-pushed the establishqualitywithpitch branch from 7952c65 to 1b667d7 Compare November 9, 2020 21:25

Be-ing requested a review from ywwg November 10, 2020 01:38

daschuer requested changes Nov 12, 2020

View reviewed changes

src/vinylcontrol/vinylcontrolxwax.cpp Outdated Show resolved Hide resolved

JoergAtGithub added 4 commits December 8, 2020 20:43

Changed establishQuality function in vinylcontrolxwax to consider the…

508b216

… pitch information additional to the position code. This results in faster response and the function provides also quality information at slow rotation

Code style

b68dcd0

Fix for -Werror=float-conversion

d68188f

Fix for -Werror=float-conversion by adding more static_cast<float> st…

9423935

…atements

JoergAtGithub force-pushed the establishqualitywithpitch branch from 6011087 to 9423935 Compare December 8, 2020 20:31

Fixed merge conflicts

d323cb2

JoergAtGithub force-pushed the establishqualitywithpitch branch from fe3f655 to d323cb2 Compare February 13, 2021 11:00

ywwg requested changes Feb 13, 2021

View reviewed changes

Replaced static casts by suffix f

78f9803

Be-ing requested a review from ywwg February 23, 2021 04:21

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Aug 29, 2021

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Aug 30, 2021

ywwg requested changes Oct 24, 2021

View reviewed changes

ywwg reviewed Nov 26, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/Main' into establishqualitywit…

fe2b854

…hpitch

JoergAtGithub force-pushed the establishqualitywithpitch branch from 5075663 to 3139d4b Compare November 26, 2021 22:37

Clamp the value from 0 to 1 to prevent the HSV warnings

49da32a

JoergAtGithub force-pushed the establishqualitywithpitch branch from 3139d4b to 49da32a Compare November 26, 2021 22:43

Fix codespell failure detected by pre-commit

e0099af

Holzhaus requested a review from daschuer December 15, 2021 08:22

ywwg approved these changes Dec 15, 2021

View reviewed changes

ywwg merged commit 983df1a into mixxxdj:main Dec 15, 2021

JoergAtGithub deleted the establishqualitywithpitch branch December 15, 2021 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved VinylControlXwax::establishQuality #3279

Improved VinylControlXwax::establishQuality #3279

JoergAtGithub commented Nov 9, 2020

Be-ing commented Dec 8, 2020

JoergAtGithub commented Jan 16, 2021

ywwg commented Jan 20, 2021

Holzhaus commented Jan 20, 2021

ywwg left a comment

ywwg Feb 13, 2021

JoergAtGithub Feb 13, 2021 •

edited

Loading

ywwg Feb 13, 2021

JoergAtGithub Feb 13, 2021

Holzhaus commented Apr 2, 2021

Holzhaus commented May 5, 2021

ywwg commented May 30, 2021

github-actions bot commented Aug 29, 2021

Be-ing commented Aug 29, 2021

Holzhaus commented Aug 29, 2021

ywwg left a comment

ywwg Nov 26, 2021

ywwg Nov 26, 2021

ywwg Nov 26, 2021

JoergAtGithub Nov 26, 2021

JoergAtGithub Dec 15, 2021

ywwg Dec 15, 2021

ywwg left a comment

JoergAtGithub commented Dec 15, 2021

Improved VinylControlXwax::establishQuality #3279

Improved VinylControlXwax::establishQuality #3279

Conversation

JoergAtGithub commented Nov 9, 2020

Be-ing commented Dec 8, 2020

JoergAtGithub commented Jan 16, 2021

ywwg commented Jan 20, 2021

Holzhaus commented Jan 20, 2021

ywwg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoergAtGithub Feb 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Holzhaus commented Apr 2, 2021

Holzhaus commented May 5, 2021

ywwg commented May 30, 2021

github-actions bot commented Aug 29, 2021

Be-ing commented Aug 29, 2021

Holzhaus commented Aug 29, 2021

ywwg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ywwg left a comment

Choose a reason for hiding this comment

JoergAtGithub commented Dec 15, 2021

JoergAtGithub Feb 13, 2021 •

edited

Loading