Column cache fix

[ywwg]

Possible fix for the columncache issues we've been having. This has a lot of debug junk in it in purpose -- please test this branch and let me know if it works for you.

[Holzhaus]

Just wondering: Does this make it possible to modify the default column order? I'ld love to move the color column to the left by default for 2.3 if possible.

[ywwg]

Just wondering: Does this make it possible to modify the default column order? I'ld love to move the color column to the left by default for 2.3 if possible.

yes, because headers are saved and restored by name, the default ordering is no longer important. (That's why I wrote this code, so headers wouldn't break on upgrade). I think this code is working in 2.2 so this shouldn't break people not on the beta build. Unfortunately 2.3 has been saving header states with blank names, so column loading will probably break for beta testers.

[ywwg]

notes addressed

[ywwg]

friendly ping

[Holzhaus]

Do you want reviews? Then you should probably mark this as ready to review and remove WIP from the title :D

[uklotzde]

Please fix the remaining pre-commit and clazy failures. We don't care about Travis ;)

[Holzhaus]

Also 2 clazy issues:

src/library/columncache.cpp#L84
allocating an unneeded temporary container [-Wclazy-container-anti-pattern]

src/library/columncache.cpp#L84
c++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop]

[ywwg]

Ah, the API I used was too new. how about this one??

[ywwg]

all checks passed yay

[ywwg]

ping

[uklotzde]

Used for verification and to prevent new conflicts in the future: ywwg#9

[uklotzde]

@Holzhaus After merging we may try again to reorder the columns.

[Holzhaus]

I noticed no issue during a small manual test. Except for the open review comment this LGTM.

[uklotzde]

@ywwg Please check my open PR with more validations and a minor improvement of the sort order code.

[ywwg]

@ywwg Please check my open PR with more validations and a minor improvement of the sort order code.

which pr?

[Be-ing]

ywwg#9

[Be-ing]

@uklotzde please leave a comment with a link in the upstream PR when you make a PR for someone's fork.

[uklotzde]

@uklotzde please leave a comment with a link in the upstream PR when you make a PR for someone's fork.

I already did, see above, cross-referenced from both sides.

[uklotzde]

3 days ago

Used for verification and to prevent new conflicts in the future: ywwg#9

[ywwg]

addressed note and merged sanity check code

[uklotzde]

Let's now give it a try after two of us have checked it. Thank you, Owen! LGTM

[uklotzde]

I will push to main, but only after testing the merged result.