Commented out debug statement causing compilation failure on OSX. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,8 +102,8 @@ | |||
| connect(m_pMasterLatency, SIGNAL(valueChanged(double)), | |||
| this, SLOT(masterLatencyChanged(double))); | |||
|
|
|||
| qDebug() << "RLimit Cur " << RLimit::getCurRtPrio(); | |||
There was a problem hiding this comment.
maybe wrap these in a linux-specific ifdef instead?
There was a problem hiding this comment.
That makes sense. I can enclose them in the ifdef that follows, which weirdly doesn't encapsulate the body of the if statement. I compared it to older code and the if body code is new and should be included in the ifdef as far as I can tell.
|
Maybe we can drop these debug messages entirely later. But for now it is a good solution. Thank you Carl! |
daschuer
added a commit
that referenced
this pull request
Jul 6, 2013
fix compilation failure on OSX.
Merged
11 tasks
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
revamp Hardware Setup chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two debugging lines introduced in dlgprefsound.cpp in commit aa2f6bf caused compilation failure on Mac OSX because they referenced Linux specific rlimit code. Removing them fixes the compilation failure.