Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapping for Behringer DDM4000 #3533

Closed
wants to merge 1 commit into from

Conversation

TheArmitage
Copy link

Hi again, I´m not sure this time i will be all ok, but gonna try.
This is my mapping for th DDM4000.
Thanks.

@ronso0
Copy link
Member

ronso0 commented Jan 6, 2021

Thanks for adding this controller!

Could you please remove those MIDI Learned from xxx messages. strings from the control descriptions?
They are useless noise for users, especially for built-in mappings. Ideally, you could replace them with meaningful terms like mixer, effects or whatever describes the category best. Then you can sort the controls table by clicking on the 'description' header which helps a lot when looking up specific controls.

@ronso0
Copy link
Member

ronso0 commented Jan 6, 2021

@Be-ing @Holzhaus
Is this a 2.3 candidate?

@ronso0 ronso0 changed the title Add Mapping fot Behringer-DDM4000 v1 Add Mapping for Behringer DDM4000 Jan 6, 2021
</control>
<control>
<group>[Library]</group>
<key>MoveHorizontal</key>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're sure this is correct?
Below you have MoveRight, maybe this should be MoveLeft?

</control>
<control>
<group>[Master]</group>
<key>gain</key>
Copy link
Member

@ronso0 ronso0 Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that this control does actually not need to be adjusted to avoid Main clipping, see https://manual.mixxx.org/2.3/en/chapters/user_interface.html#headphone-and-master-mix-controls > Master knob
(except you pipe through some quiet Aux signal or Mic signal)

In case this knob also works as hardware control for the main output it's recommended to not map its MIDI signal.

@ronso0
Copy link
Member

ronso0 commented Jan 6, 2021

@Be-ing @Holzhaus
Is this a 2.3 candidate?

This mapping is a pure MIDI mapping and it does not make use of features in main so it can go to 2.3

@TheArmitage Could you target this at 2.3? Edit the PR title to change the base branch to 2.3, and rebase locally git rebase -i [your mixxx-remote repo name]/2.3, then force-push to this branch.

@ronso0
Copy link
Member

ronso0 commented Jan 6, 2021

Please also add a manual page for this controller to the 2.3 manual
see documenting-the-mapping, just copy/rename an existing page in /hardware/controllers which is much easier than creating a new one from scratch.

@Holzhaus
Copy link
Member

Holzhaus commented Jan 6, 2021

@TheArmitage Could you target this at 2.3? Edit the PR title to change the base branch to 2.3, and rebase locally git rebase -i [your mixxx-remote repo name]/2.3, then force-push to this branch.

This is probably easier if you don't have much experience with git: https://github.com/mixxxdj/mixxx/wiki/Using%20Git#targeting-another-base-branch

@uklotzde
Copy link
Contributor

uklotzde commented Jan 6, 2021

A much more sophisticated mapping seems to be in development already: #3342 (comment)

@git-developer @TheArmitage Please connect with each other for development and testing. We should add only a single mapping.

@git-developer
Copy link
Contributor

I agree that one mapping should be enough.

@TheArmitage, your mapping contains

  • Channel 1-4: Volume, PFL, Equalizer Knobs & Kill Switches
  • Crossfader: Fader
  • Library navigation via Sampler buttons
  • Beat Indicator via CF Assign LEDs

My mapping contains

  • Channel 1-4: Volume, Crossfader Assignment, PFL, Equalizer Knobs & Kill Switches
  • Microphone: Talkover
  • Crossfader: Fader, Curve, Reverse Tap, Reverse Hold
  • Sampler 1: Volume, PFL, Play, Reverse, Repeat, FX; LED behaviour as in native mixer
  • Sampler 2: Play, Reverse, Repeat, FX; LED behaviour as in native mixer

I prepared a manual page but didn't create a PR for it yet.

On my todo list is to check if the sampler beat buttons may be used to control sampler loop size, and revisit if Mixxx supports some of the MIC controls.

How important are navigation and beat indication for you? The mixer still has buttons that are unused, e.g. CF Kill switches, CF Beat buttons, MIC buttons and knobs. What do you think of using some of these if you need them?

@TheArmitage
Copy link
Author

Hi, please do not missunderstand me, I´ve did this mapping some months ago (as a hobby confined in my home), my goal is my personal use of the mixer with the program. I didn´t want to spread it, but I thought it will be selñfish. Then someone ask me to share it with the correct way and I put off this idea until tomorrow.

If you have a better mapping and you´re taking your time to make it well I don´t need to make anything else, I will be waiting your mapping.

Thanks.

@git-developer
Copy link
Contributor

OK, then once again thanks for all your efforts and sharing your mapping! I wouldn't have started without your mapping.

I guess it's not possible to "take over" a pull request, so I suppose that I open a new Draft PR, link it to this one so that this one may be closed. Would that be OK?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 7, 2021

I guess it's not possible to "take over" a pull request, so I suppose that I open a new Draft PR, link it to this one so that this one may be closed. Would that be OK?

Yes.

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Apr 8, 2021
@uklotzde
Copy link
Contributor

uklotzde commented May 7, 2021

Closing in favor of #3542

@uklotzde uklotzde closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller mappings stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants