Tooltips and CVS Export: Use BPM precision of four integer digits #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is required to verify if a track is at a full 1/12 bpm.
Merged
uklotzde
suggested changes
Feb 15, 2021
uklotzde
reviewed
Feb 21, 2021
src/library/basetracktablemodel.h
Outdated
| @@ -16,6 +16,9 @@ class BaseTrackTableModel : public QAbstractTableModel, public TrackModel { | |||
| DISALLOW_COPY_AND_ASSIGN(BaseTrackTableModel); | |||
|
|
|||
| public: | |||
| // This role is used for data export like in CSV files | |||
| static constexpr int kDataExportRole = Qt::UserRole + 1; | |||
There was a problem hiding this comment.
The base class TrackModel already defines constants for. Qt::UserRole + 0 and Qt::UserRole + 1. Potential conflict?
There was a problem hiding this comment.
Not really, because it is used is a different context. However, I have moved it to TrackModel anyway, to avoid future confusion.
uklotzde
reviewed
Feb 23, 2021
|
Done. |
uklotzde
reviewed
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to verify if a track is at a full 1/12 bpm.
The idea to use the tool-tips to show a higher precision was discussed here #2001
but it looks like it has slipped through the original review.
We want also full precision in cvs exports. This way we export the truth and not the optimized value for displaying purpose.