Skin fixes for 2.3

[ronso0]

• LateNight PaleMoon: visualize fx flow and more small improvements, css clean up, documentation
  

• Tango: fx layout fix https://bugs.launchpad.net/mixxx/+bug/1919378

• Deere: push fx parameter buttons apart

[Holzhaus]

Thanks, the screenshot looks good. But I would look even better if the dark area around FX 1 and FX 3 had the same width. What do you think?

[ronso0]

sure it would.
I'd prefer to not make the expanded unit's label wider because it is the header for the controls below.
making the collapsed unit label wider which would steal width from the effectselectors (I still have the minimum skin size in mind where the entire skin is a bit tight)

[ronso0]

so there's no real solution for polishing this spot, unless we ignore the condensed layout

[Holzhaus]

so there's no real solution for polishing this spot, unless we ignore the condensed layout

We could make mixing button a bit slimmer (currently it's wider than the PFL button). That would solve the issue and also look less crammed on small screens when the unit is collapsed.

[ronso0]

reason for the mixmode button being wide is that as square icon it looks too much like a Close button (D/W mode) and should resemble something like a crossfader mix curve. so I wouldn't want to change that.

we could move the Pfl button below the mixmode, so when expanding an Fx unit the entire control section is flipped from an h-layout to a v-layout.

but since the functional and usefull changes are in place now I'd rather postpone aesthetic fixes until the menubar topic is finished.

[Holzhaus]

Tango looks still broken for me:

[ronso0]

in your screencast is there space below the mic section?
anyways, I'll take a look

[Holzhaus]

Here's a new screencast that captures the whole window and shows all 3 skins.

I also noticed that the padding in the effect selector in deere looks wrong, but that shouldn't block this PR.

[ronso0]

thanks for the overview!
I already fixed WEffectSelector:!editable::on in LateNight. easy to port to other skins
(until now I thought it's just Windows where the selector is visible when the list is unrolled)

[ronso0]

@Holzhaus if you find time, please check the effect selector again in Deere and Shade.
Also the Tango fx layout has a fixed height now.

[Holzhaus]

Thanks, I had a look at all skins and they look fine now.

[NotYourAverageAl]

@ronso0 this PR seems to have messed my window10 gui and effect names are cutoff. Though is looks fine on your screenshot

before

This PR

[ronso0]

okay, so there are actually people using LateNight

• @1280px (or FHD @150%)
• with super knobs
• and with focus shown while the fx unit is collapsed

I wlll adjust the minimal size, of course.

[Holzhaus]

@NotYourAverageAl it looks like the effect names were cutoff in the before screenshot, too?

[NotYourAverageAl]

@Holzhaus wrong choice of words...I meant the effect name box is now cutoff by the >

@ronso0 if you build it I'll find a way to break it :)

[ronso0]

@NotYourAverageAl fixed in #3788