Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tango: sort templates into subfolders #3807

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Apr 27, 2021

basically a no-op PR to ease maintenance.
based on #3788 and I'll rebase when that's merged.

I tested both Tango and Tango64, but of course further testing is appreciated as something may have slipped through.

quirk:
the main templates were already linked as skin:../Tango/.. but after applying that pattern for ALL templates I also had to change the icon paths in style.qss 😕

@ronso0
Copy link
Member Author

ronso0 commented May 3, 2021

rebased, ready!

@ronso0 ronso0 marked this pull request as ready for review May 3, 2021 01:51
@ronso0
Copy link
Member Author

ronso0 commented May 3, 2021

Ready!

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Waiting for CI.

@Holzhaus Holzhaus merged commit 320f55c into mixxxdj:2.3 May 3, 2021
@ronso0 ronso0 deleted the tango-subfolders branch May 3, 2021 22:10
ronso0 added a commit to ronso0/mixxx that referenced this pull request May 20, 2021
Holzhaus added a commit that referenced this pull request May 21, 2021
Tango64: adjust template to new folder structure #3807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants