Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1929311: TagLib: Check for existence of tags before export #3898

Merged
merged 3 commits into from
May 25, 2021
Merged

lp1929311: TagLib: Check for existence of tags before export #3898

merged 3 commits into from
May 25, 2021

Conversation

uklotzde
Copy link
Contributor

https://bugs.launchpad.net/mixxx/+bug/1929311

Do not create additional file tags if they do not already exist.

@uklotzde uklotzde added this to the 2.3.0 milestone May 23, 2021
@uklotzde uklotzde mentioned this pull request May 23, 2021
Closed
daschuer
daschuer requested changes May 24, 2021
View reviewed changes
src/sources/metadatasourcetaglib.cpp Outdated Show resolved Hide resolved
@uklotzde uklotzde requested a review from daschuer May 24, 2021 23:55
daschuer
daschuer approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@daschuer daschuer merged commit 6dd85df into mixxxdj:2.3 May 25, 2021
@uklotzde uklotzde deleted the taglib-file-tags branch May 25, 2021 09:33
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
blocker library major bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer