Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the not working binary file check #3916

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

daschuer
Copy link
Member

The code requires that the first Char is either ASCII or a BOM, which is not the case if the file starts with a cyrilic char or a Windows-1252 char like Ü

This issue was reported here:
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Mixxx.20can.20not.20load.20m3u8.20playlist

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit 7411d0d into mixxxdj:2.3 May 26, 2021
@daschuer daschuer deleted the m3u8 branch September 26, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants