-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partially revert #3902 Skins: fix qss icons with kIconThemes 5.80 #3931
Conversation
voila, more time wasted. looking forward to fix the conflicts with main |
c978596
to
34188fb
Compare
because with scale factors >100% the (vector) icons set with 'background[-mage]' are not truely scaled up, only their 100% pixmap, which results in blurry/ pixelated icons. Users still with broken libKIconThemes5 v5.80 have to live with squeezed icons until they (can) update that lib.
34188fb
to
8d81163
Compare
can confirm this results in squeezed images on ubuntu 21.04 |
I can confirm this fixes the pixelated icons with double scaling. It also fixes the square BPM Slider center indicator in LateNight (this even happens without scaling). Merge? |
I couldn't simply revert the PR because it contained other fixes, and because I pushed another small fix later. |
with the new deb from the PPA, skins look good on ubuntu. ok to merge by me |
I found some issues like double preview icons in the library (from default.qss and skin style) |
fixed of course after rebuilding. D O N E !!! |
stupid me,. I had two 'revert' branches and applied that small fixes to the wrong one. I'll push those directly. |
and I'm merging to main now |
because with scale factors >100% the (vector) icons set with 'background[-mage]' are not truely scaled up, only their 100% pixmap, which results in blurry/pixelated icons.
Users still with broken libKIconThemes5 v5.80 have to live with squeezed icons until they (can) update that lib.
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/2.2E3.20planning.3A.20https.3A.2F.2Fgithub.2Ecom.2Fmixxxdj.2Fmixxx.2Fprojects.2F2/near/240843338