Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete Ubuntu Bionic 18.04 #3985

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Obsolete Ubuntu Bionic 18.04 #3985

merged 5 commits into from
Jun 14, 2021

Conversation

uklotzde
Copy link
Contributor

  • Update comments
  • Update clang format settings
  • Remove obsolete workaround
  • Remove obsolete references in CI build
  • Upgrade actions-setup-cmake in CI build

TODO:

  • Update PPA build

@uklotzde uklotzde added this to the 2.4.0 milestone Jun 12, 2021
@github-actions github-actions bot added the ui label Jun 12, 2021
@uklotzde uklotzde marked this pull request as ready for review June 12, 2021 15:23
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.
What needs to be done at the PPA?

@uklotzde
Copy link
Contributor Author

LGTM, Thank you.
What needs to be done at the PPA?

I deliberately excluded all PPA tasks, because I am not aware of all the subtleties and potential pitfalls.

@daschuer
Copy link
Member

That's no Problem. I will take care.
I just like to know what is to do for the PPA build.
I don't see a anything.

@Holzhaus
Copy link
Member

Holzhaus commented Jun 14, 2021

Maybe delete the Ubuntu 18.04 package, so that users get a warning from their package manager that the package is not updated any longer.

@uklotzde
Copy link
Contributor Author

uklotzde commented Jun 14, 2021

@daschuer Regarding the PPA: I was unsure if you want to delete all the conditionals that were required for supporting different releases with differing dependencies.

Do we distribute main builds through the PPA?? Then we definitely need to delete those 18.04 packages.

@daschuer
Copy link
Member

@daschuer
Copy link
Member

Thank you for taking care.

@daschuer daschuer merged commit 3ddbbae into mixxxdj:main Jun 14, 2021
@uklotzde uklotzde deleted the obsolete-ubuntu-bionic-18.04 branch June 15, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants