Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DlgPrefController: don't enable checkbox if controller is disabled #4244

Merged
merged 1 commit into from
Aug 25, 2021
Merged

DlgPrefController: don't enable checkbox if controller is disabled #4244

merged 1 commit into from
Aug 25, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 25, 2021

@Be-ing Be-ing requested a review from Holzhaus August 25, 2021 06:45
@Be-ing Be-ing mentioned this pull request Aug 25, 2021
Merged
uklotzde
uklotzde approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, changes are reasonable.

@uklotzde uklotzde added this to the 2.3.1 milestone Aug 25, 2021
@daschuer
Copy link
Member

This only eleminates a local variable, right?
How does it fix:
https://bugs.launchpad.net/mixxx/+bug/1941042

@uklotzde
Copy link
Contributor

This only eleminates a local variable, right?
How does it fix:
https://bugs.launchpad.net/mixxx/+bug/1941042

The local variable was initialized before invoking enumeratePresets(). The side-effects are explained in the comment.

@uklotzde
Copy link
Contributor

This only eleminates a local variable, right?
How does it fix:
https://bugs.launchpad.net/mixxx/+bug/1941042

The local variable was initialized before invoking enumeratePresets(). The side-effects are explained in the comment.

It's not the local variable but the timing of when setting the checkbox.

@uklotzde
Copy link
Contributor

I expect that everyone on the same page now. LGTM

@uklotzde uklotzde merged commit 10031e0 into mixxxdj:2.3 Aug 25, 2021
@Be-ing Be-ing deleted the controller_enabled_checkbox branch August 25, 2021 23:52
@Be-ing Be-ing added the changelog This PR should be included in the changelog label Aug 26, 2021
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

Assignees
No one assigned
Labels
changelog This PR should be included in the changelog
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @daschuer @uklotzde