Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HidEnumerator: skip all HID devices with Apple's vendor ID #4260

Merged
merged 1 commit into from
Sep 5, 2021
Merged

HidEnumerator: skip all HID devices with Apple's vendor ID #4260

merged 1 commit into from
Sep 5, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Sep 4, 2021

uklotzde
uklotzde approved these changes Sep 4, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that.

@uklotzde uklotzde added the changelog This PR should be included in the changelog label Sep 4, 2021
@uklotzde uklotzde added this to the 2.3.1 milestone Sep 4, 2021
@uklotzde
Copy link
Contributor

uklotzde commented Sep 4, 2021

Please add a changelog entry!

Could we be sure that we don't break existing use cases? Or play it safe and target main instead of 2.3?

@ronso0
Copy link
Member

ronso0 commented Sep 4, 2021 •
edited
Loading

since Apple doesn't build actual controllers, one use case would be to have a (second) Magic Mouse and use that for whatever, scratching..?
safe to break those rare cases if that fixes issues for all other mac users, no?

@uklotzde
Copy link
Contributor

uklotzde commented Sep 5, 2021

No objections, then let's merge. LGTM

@uklotzde uklotzde merged commit 8a93f36 into mixxxdj:2.3 Sep 5, 2021
@Be-ing Be-ing deleted the hid_apple_block branch September 5, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
changelog This PR should be included in the changelog
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @uklotzde @ronso0