Don't disable loop cues when latching it via play. lp1942656 #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes also a segfault that happens when deleting a cue in preview state.
Be-ing
reviewed
Sep 6, 2021
Comment on lines
-1924
to
+1936
| updateCurrentlyPreviewingIndex(Cue::kNoHotCue); | ||
| int oldPreviewingIndex = | ||
| m_currentlyPreviewingIndex.fetchAndStoreRelease( | ||
| Cue::kNoHotCue); | ||
| if (oldPreviewingIndex >= 0 && oldPreviewingIndex < m_iNumHotCues) { | ||
| HotcueControl* pLastControl = m_hotcueControls.at(oldPreviewingIndex); | ||
| mixxx::CueType lastType = pLastControl->getPreviewingType(); | ||
| if (lastType != mixxx::CueType::Loop) { | ||
| CuePointer pLastCue(pLastControl->getCue()); | ||
| if (pLastCue && pLastCue->getType() != mixxx::CueType::Invalid) { | ||
| pLastControl->setStatus(HotcueControl::Status::Set); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should this code go in updateCurrentlyPreviewingIndex instead?
There was a problem hiding this comment.
That does not work here, because we need to keep the active state of the loop cue here for latching. Using updateCurrentlyPreviewingIndex in both cases was the root cause of this bug.
|
Thank you for working on this. I confirm it does fix the bug. I am not certain this is the best place to put the fix in the code. |
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes also a segfault that happens when deleting a cue in preview state.