Library: add keyboard short to open track properties Ctrl+Enter #4347
Conversation
|
Why do you pick exactly Ctrl+Enter |
|
Oh I just.. just tried it here and it is the short cut for the comment button. |
|
The original report suggests CTRL+i which is used in VLC player to show the metadata of the playing track and in iTunes the info of the selected track and takes a screenshot in Windows Media Player. Did you consider to use Ctrl+i instead? |
|
I picked
I'd rather not look at how unrelated apps use the key. |
|
The shortcut is now displayed in the track menu, at least in the tracks table menu which is sufficient. |
ronso0
force-pushed
the
trackproperties-hotkey
branch
from
b88865d
to
32c835e
Compare
ronso0
force-pushed
the
trackproperties-hotkey
branch
from
32c835e
to
a2e5373
Compare
src/widget/wtrackmenu.cpp
Outdated
| // when the menu is invoked from the tracks table. | ||
| // The actual shortcut is set in WTrackTableView::keyPressEvent | ||
| if (m_pTrackModel) { | ||
| m_pPropertiesAct->setShortcut(QKeySequence(tr("Ctrl+Return"))); |
There was a problem hiding this comment.
I think QKeySequence has translation under the hood, no need for() tr here.
Is there a common header where we can move it to? This allows to define it only in a single place.
There was a problem hiding this comment.
Indeed, QKeySequence(Qt::CTRL + Qt::Key_Return) works, too.
I'd appreciate to have one place for those shortcuts, sure. defs_urls.h could work, but then we'd need to complicate WTrackTableView::keyPressEvent to look it up, too.
Though I wonder if it's worth the hassle considering it's about one shortcut only (maybe also Del from #4330).
There was a problem hiding this comment.
I've put it in util/defs.h, okay?
src/widget/wtracktableview.cpp
Outdated
| } else { | ||
| QTableView::keyPressEvent(event); | ||
| // If Ignore all Enter combos if any cell editor is open | ||
| if (event->key() == Qt::Key_Return && |
There was a problem hiding this comment.
unlike many other keys Qt::Key_Return does not reach this function it is already used for
[PreviewDeck1],start_stop
There was a problem hiding this comment.
oh. I had a custom kbd config in place which didn't contain this shortcut. also it does not work when I have no kbd config in .mixxx that contains it and start mixxx from the build directory. strange..
And it needs to be added to the keyboard shortcut PDF/image.
Anyway, then let's not use it. We could argue if Return is maybe better used for the double click action, not for the preview deck, but that doesn't need to happen here.
There was a problem hiding this comment.
We could argue if Return is maybe better used for the double click action
I can confirm that.
ronso0
force-pushed
the
trackproperties-hotkey
branch
from
c859196
to
68c8941
Compare
ronso0
force-pushed
the
trackproperties-hotkey
branch
from
68c8941
to
8a7c4b0
Compare
https://bugs.launchpad.net/mixxx/+bug/1393357
In the tracks table press
Ctrl+Returnto show the Track Properties dialog for the selected track.The shortcut is displayed in the track context menu (only when invoked from the tracks table).