Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects refactoring minor changes #4482

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

daschuer
Copy link
Member

Here some minor changes and style improvements, found during testing.

@github-actions github-actions bot added the ui label Oct 24, 2021
@daschuer daschuer mentioned this pull request Oct 24, 2021
17 tasks
@Be-ing
Copy link
Contributor

Be-ing commented Oct 24, 2021

/home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp: In member function ‘void DlgPrefEQ::slotNumDecksChanged(double)’:
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:126:33: error: ‘qEqComboBox’ was not declared in this scope; did you mean ‘pEqComboBox’?
  126 |         gridLayout_3->addWidget(qEqComboBox, deckNo, 1);
      |                                 ^~~~~~~~~~~
      |                                 pEqComboBox
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:130:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  130 |                 3,
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:131:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  131 |                 1,
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:17: error: right operand of comma operator has no effect [-Werror=unused-value]
  132 |                 1);
      |                 ^
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:18: error: expected ‘;’ before ‘)’ token
  132 |                 1);
      |                  ^
      |                  ;
Error: /home/runner/work/mixxx/mixxx/src/preferences/dialog/dlgprefeq.cpp:132:19: error: right operand of comma operator has no effect [-Werror=unused-value]
  132 |                 1);
      |                   ^

@daschuer
Copy link
Member Author

Oh sorry, I have messed up one commit when trying to group my random changes reasonable. I have rebased the PR to have all commits building again.

src/preferences/dialog/dlgprefeq.cpp Outdated Show resolved Hide resolved
@uklotzde
Copy link
Contributor

LGTM

@uklotzde uklotzde merged commit 5e2bbb2 into mixxxdj:effects_refactoring Oct 25, 2021
@daschuer daschuer deleted the effects_refactoring_6 branch April 14, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants