Log re-import of track metadata from file tags with time stamps #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the boolean result from updateTrackFromSource() with a dedicated result enum that allows to distinguish the different outcomes.
uklotzde
commented
Jan 18, 2022
| << "Updated track metadata from file tags:" | ||
| << pTrack->getFileInfo().lastModified() | ||
| << pTrack->getMetadata(); | ||
| DEBUG_ASSERT(!pTrack->isDirty()); |
There was a problem hiding this comment.
I have added lots of debug assertions here to verify the assumptions.
NOTE: I didn't test if these debug assertions still work without the fixes from #4628.
There was a problem hiding this comment.
It should, since you just set pTrack->markClean(); above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the boolean result from updateTrackFromSource() with a dedicated result enum that allows to distinguish the different outcomes.
Related to #4628 for debugging purposes. Easier to review as a standalone PR.