Add colored hotcues for Traktor Kontrol S2 MK3 #4637
Conversation
Co-authored-by: ronso0 <ronso0@mixxx.org>
|
|
||
| }; | ||
|
|
||
| // Mixxx hotcue colors |
There was a problem hiding this comment.
These are Traktor's hotcue colors, not Mixxx', right? These RGB values should be the equivalent of the color you actually see on the controller when you send the midi value.
There was a problem hiding this comment.
Nono, this should be the RGB-Colors, the mixxx palette uses. I tried to find a very close color on the pads for each of the palette colors. It is hard to determine the exact RGB-colors the pads have but it should be close.
There was a problem hiding this comment.
Nono, this should be the RGB-Colors, the mixxx palette uses. I tried to find a very close color on the pads for each of the palette colors.
This is not how the color mapper works. The RGB colors should resemble the pads as close as possible. The Mixxx palette is unrelated, and can be configured with arbitrary colors anyway.
It is hard to determine the exact RGB-colors the pads have but it should be close.
I suppose for most of the colors you can take a screenshot of the Traktor GUI and then use a color picker. I'm pretty sure these colors match the LEDs on the controller. Then you know the exact RGB values of green (saved loops), blue (hot cues), white (grid markers), yellow (load in) and orange (fade in/out). The RGB colors (purple/pink/celeste/red) need to be guessed.
There was a problem hiding this comment.
I have no windows PC so I cannot run traktor. However, I took photos of every possible pad color and analyzed them in gimp using the color picker with an average filter. The result that I see now for the hotcue colors I use looks pretty nice.
| engine.setValue(field.group, "LoadSelectedTrack", field.value); | ||
| engine.setValue(field.group, "pfl", 1); | ||
| } |
There was a problem hiding this comment.
Yes, sorry, force of habit. I am always thinking of an option in the settings for enabling PFL on track loading.
|
BTW: Good to see you guys are still here. I didn't contribute for a while but I will try to do little things again in the future. |
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
|
@goddisignz Thank you, for your contribution! |
JoergAtGithub
added
changelog
|
Is this a candidate for back-porting to the stable 2.3 branch es well? |
|
This will not work on 2.3 as it is, due to ES6 syntax. But it should go into 2.4. |
Title already says it. I implemented the Mixxx color palette for the hotcue pads of the Traktor Kontrol S2 MK3.