Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traktor library: fix importing track key #4701

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

remus32
Copy link
Contributor

@remus32 remus32 commented Mar 23, 2022

It looks like there used to be a KEY attribute in the INFO tag

key = attr.value("KEY").toString();
but Traktor 3.5.1 (the latest version) does not use this and has a MUSICAL_KEY node in ENTRY instead.

The keys are converted to string during import and are therefore immune to changes to preferred key notation in preferences.

@daschuer
Copy link
Member

daschuer commented Apr 4, 2022

Thank you very much for this PR. It looks good to me.
Before merge, we need you permission to distribute your changes.
Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
and comment here when done.

@remus32
Copy link
Contributor Author

remus32 commented Apr 5, 2022

Done

src/library/traktor/traktorfeature.cpp Outdated Show resolved Hide resolved
@daschuer
Copy link
Member

daschuer commented Apr 6, 2022

Thank you :-)

@daschuer daschuer merged commit b2401b9 into mixxxdj:main Apr 6, 2022
@daschuer daschuer added this to the 2.4.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants