WTrackMenu: show 'Update ReplayGain' only in decks' menus #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
updategain-trackmenu
branch
from
0b114b9
to
a3286f1
Compare
ronso0
changed the title
daschuer
reviewed
Apr 13, 2022
src/widget/wtrackmenu.cpp
Outdated
| // This action is only usable when m_deckGroup is set. That is true only | ||
| // for WTrackmenu instantiated by WTrackProperty and other deck widgets, thus | ||
| // don't create it if a track model is set. | ||
| if (!m_pTrackModel && featureIsEnabled(Feature::UpdateReplayGain)) { |
There was a problem hiding this comment.
How about renaming the enum also to "UpdateReplayGainFromDeckGain"? I was unital confused why a deck is required for updating the replay gain form metadata.
There was a problem hiding this comment.
Sure, if it helps avoiding confusion.
There was a problem hiding this comment.
The respective slot is slotUpdateReplayGainFromPregain so I'd adopt that for the enum.
Is this more clear?
|
Thank you! |
|
I think it is save to merge even without @ywwg having a look. |
|
I'm still curious why it was implemented this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing that the "Update ReplayGain" action is shown in the track table menu but always greyed out (and it's pointless there anyway because the menu is not related to a deck).
This also reverts 576e2cf
It's okay to debug assert if a model is asked about a unsupported feature -- that line is never reached if we check for
!m_pTrackModelwhen creating the "Update ReplayGain" action@ywwg What do you think?
gaintooltip?