-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization maintance #4785
Conversation
…sts or where it eqauals the parent language
…y QLocale and than zh_TW is picked
Please provide more context. The standalone PR is not reviewable without this information. |
You will receive everything you pull from Transiflex. It is a question of what we add to the Mixxx GitHub repository. Currently the instructions are written to pull everything above 1% translated strings and then add every new language. I think this need to be adjusted. We need to do a plausibility check before adding new languages. I have already removed the unsupported languages from Transiflex, so that they will not come back. I will update the wiki accordingly. |
Doesn't the Should we remove the |
Yes, it does. The -f option is described here: It ensures that local changes are discarded. |
I have added the -f and --minimum-perc flags to the wiki description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for amending the documentation! LGTM
This adds new languages, removes redundant languages and languages with only a few strings translated < 1 %
This also fixes: https://bugs.launchpad.net/mixxx/+bug/1837663
This webside was helpfull for a quick reference of language codes:
https://www.localeplanet.com/icu/iso639.html