Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization maintance #4785

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 5, 2022

This adds new languages, removes redundant languages and languages with only a few strings translated < 1 %

This also fixes: https://bugs.launchpad.net/mixxx/+bug/1837663

This webside was helpfull for a quick reference of language codes:
https://www.localeplanet.com/icu/iso639.html

@uklotzde
Copy link
Contributor

uklotzde commented Jun 6, 2022

  • How do we prevent the removed translations from re-appearing when pulling translations from Transifex?
  • Is the process for updating translations affected and does it need to be updated?

Please provide more context. The standalone PR is not reviewable without this information.

@daschuer
Copy link
Member Author

daschuer commented Jun 6, 2022

How do we prevent the removed translations from re-appearing when pulling translations from Transifex?

You will receive everything you pull from Transiflex. It is a question of what we add to the Mixxx GitHub repository. Currently the instructions are written to pull everything above 1% translated strings and then add every new language. I think this need to be adjusted. We need to do a plausibility check before adding new languages.

I have already removed the unsupported languages from Transiflex, so that they will not come back.

I will update the wiki accordingly.

@daschuer
Copy link
Member Author

daschuer commented Jun 6, 2022

@uklotzde
Copy link
Contributor

uklotzde commented Jun 6, 2022

See: https://github.com/mixxxdj/mixxx/wiki/Internationalization

Doesn't the --minimum-perc option exclude all languages below the given threshold, both existing and new ones?

Should we remove the -f option? It is not mentioned why it is needed and the docs of tx also don't explain it properly.

@daschuer
Copy link
Member Author

daschuer commented Jun 7, 2022

Doesn't the --minimum-perc option exclude all languages below the given threshold, both existing and new ones?

Yes, it does.

The -f option is described here:
https://docs.transifex.com/client/pull

It ensures that local changes are discarded.

@daschuer
Copy link
Member Author

daschuer commented Jun 7, 2022

I have added the -f and --minimum-perc flags to the wiki description

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for amending the documentation! LGTM

@uklotzde uklotzde merged commit dbd6709 into mixxxdj:main Jun 7, 2022
@daschuer daschuer deleted the internationalization branch October 12, 2022 12:04
@daschuer daschuer added this to the 2.4.0 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants