Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LateNight: remove blinking play indicator from mini samplers #4807

Merged
merged 1 commit into from
Jun 17, 2022
Merged

LateNight: remove blinking play indicator from mini samplers #4807

merged 1 commit into from
Jun 17, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jun 16, 2022 •
edited
Loading

probably a copy/paste mistake.
It's not implemented in other skins and LateNight's regular samplers.
because it's annoying.
and doesn't make much sense either since the samplers' Play button triggers cue_gotoandplay.

@ronso0 ronso0 marked this pull request as ready for review June 16, 2022 19:41
@github-actions github-actions bot added the skins label Jun 16, 2022
daschuer
daschuer approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, Thank you.

@daschuer daschuer merged commit c754e70 into mixxxdj:2.3 Jun 17, 2022
@ronso0 ronso0 deleted the latenight-samplers-remove-blink branch June 17, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
skins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer