-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows clang-cl build #4866
Windows clang-cl build #4866
Conversation
It would be interesting how a mingw gcc build will perform. |
Mingw is wormhole of problems, you would need to change the code at numerous places. Once I spend hours on a simple command line programm, due to differences in the implementation in the C standard function scanf. Clang-cl is just a drop in for MSVC - only the compiler itself is changed and creates ABI compatible binaries, PDB files etc. |
This PR is marked as stale because it has been open 90 days with no activity. |
f36f442
to
ba05616
Compare
…d types 'QDebug' and 'TagLib::FileName')
1d4e56f
to
90aafb7
Compare
I intend to delete the GitHub build action before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything left to do here?
After merging this, we will have two windows build for every PR, a waste of energy if we will not use it, do we? |
Yes, the CI build was only for testing. I will remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for ci. thank you
This is an experimental build with the clang-cl compiler that comes with VisualStudio 2019.
clang-cl is a clang compiler variant, with MSVC compatible command line interface.
The CI build fails due to a header of protobuf, which is part of the Windows buildenv. I could fix this locally by applying: protocolbuffers/protobuf@1d2e8d9
My local build succeed, passed all tests and works flawless. But it feels slower than the MSVC build - I expected the opposite after the auto-vectoization results from @daschuer in #4861