Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VAMP plugin support. #926

Merged
merged 47 commits into from
Dec 30, 2018
Merged

Remove VAMP plugin support. #926

merged 47 commits into from
Dec 30, 2018

Commits on Jan 31, 2016

  1. Delete most VAMP code and move Queen Mary DSP library to lib/qm-dsp.

    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    2147838 View commit details
    Browse the repository at this point in the history

  2. Remove VAMP from NSIS.

    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    28f2661 View commit details
    Browse the repository at this point in the history

  3. Remove VAMP from Travis and README.

    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    1b74041 View commit details
    Browse the repository at this point in the history

  4. Introduce interface for key and beat detection plugins.

    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    d1b46aa View commit details
    Browse the repository at this point in the history

  5. Use AnalyzerPlugin interface in AnalyzerKey/AnalyzerBeats and prefere… 

    …nces.
    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    0e5ee97 View commit details
    Browse the repository at this point in the history

  6. Add helper for performing mono downmixing, conversion and overlapped 

    windowing of buffers.

The Queen Mary detectors expect 50% overlapping windows of samples to be
fed to them. They also use double samples instead of float.
    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    b3a271a View commit details
    Browse the repository at this point in the history

  7. Add AnalyzerQueenMaryKey. 

    Uses the qm-dsp library to calculate the key mode of the track. This is
a re-write of the VAMP plugin so the parameters used are the same.
    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    1ddf808 View commit details
    Browse the repository at this point in the history

  8. Add AnalyzerQueenMaryBeats and AnalyzerSoundTouchBeats. 

    Uses SoundTouch and qm-dsp libraries to calculate BPM and do beat
tracking. Replicates the logic of our VAMP plugins so the parameters to
the algorithms are the same.
    @rryan
    rryan committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    1f5a60b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2016

  1. Merge branch 'master' into remove-vamp

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    73bd4a5 View commit details
    Browse the repository at this point in the history

  2. Remove VAMP from .travis.yml.

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    4675155 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into remove-vamp

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    8be4027 View commit details
    Browse the repository at this point in the history

  4. Remove manual setting/getting of beat detector preferences. 

    * Introduce BeatDetectionSettings helper class.
* Remove UserSettingsPointer direct usage from DlgPrefBeats,
  AnalyzerBeats, AnalysisFeature, and Upgrade.
* Delete beat_preferences.h.
    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    8bcbf81 View commit details
    Browse the repository at this point in the history

  5. Remove manual setting/getting of key detector preferences. 

    * Introduce KeyDetectionSettings.
* Use KeyDetectionSettings in DlgPrefKey and AnalyzerKey.
* Delete key_preferences.h.
    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    515428f View commit details
    Browse the repository at this point in the history

  6. Don't hard-code plugin ids.

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    af26041 View commit details
    Browse the repository at this point in the history

  7. Use common default values.

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    56a3363 View commit details
    Browse the repository at this point in the history

  8. Oops.

    @rryan
    rryan committed Apr 17, 2016
    Configuration menu
    Copy the full SHA
    d4e03d1 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. Merge branch 'master' into remove-vamp

    @rryan
    rryan committed May 6, 2016
    Configuration menu
    Copy the full SHA
    f841629 View commit details
    Browse the repository at this point in the history

  2. Use consistent quotes.

    @rryan
    rryan committed May 6, 2016
    Configuration menu
    Copy the full SHA
    4f9e690 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2016

  1. Merge branch 'master' into remove-vamp

    @rryan
    rryan committed May 23, 2016
    Configuration menu
    Copy the full SHA
    9ef88ab View commit details
    Browse the repository at this point in the history

  2. Rename default accessor to setNameToDefault.

    @rryan
    rryan committed May 23, 2016
    Configuration menu
    Copy the full SHA
    19591f7 View commit details
    Browse the repository at this point in the history

  3. Note, don't warn.

    @rryan
    rryan committed May 23, 2016
    Configuration menu
    Copy the full SHA
    49c84be View commit details
    Browse the repository at this point in the history

  4. Drop some comments and remove template in DownmixAndOverlapHelper.

    @rryan
    rryan committed May 23, 2016
    Configuration menu
    Copy the full SHA
    db8cc6a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Merge branch 'master' into remove-vamp

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    7e4d9f9 View commit details
    Browse the repository at this point in the history

  2. Fix the build.

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    1fcbf31 View commit details
    Browse the repository at this point in the history

  3. Reword block to window throughout.

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c7a1c76 View commit details
    Browse the repository at this point in the history

  4. Don't build modules we don't need from qm-dsp.

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    74c06ac View commit details
    Browse the repository at this point in the history

  5. Remove vamppluginadapter.h/cpp.

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    0af7131 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'mixxxdj/master' into remove-vamp

    @rryan
    rryan committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    cfb18c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Remove plugins directory from Wix script.

    @rryan
    rryan committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    ceb1aa4 View commit details
    Browse the repository at this point in the history

  2. Remove const qualifiers on AnalyzerPlugin members to avoid deleting t… 

    …he implicit copy assignment constructor.
    @rryan
    rryan committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    cfa1f63 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Merge remote-tracking branch 'mixxxdj/master' into remove-vamp

    @rryan
    rryan committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    d0e2d2d View commit details
    Browse the repository at this point in the history

  2. Don't sign non-existent vamp plugins.

    @rryan
    rryan committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    c05360f View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Merge remote-tracking branch 'mixxxdj/master' into remove-vamp

    @rryan
    rryan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    974bb2a View commit details
    Browse the repository at this point in the history

  2. Disable key analysis options when key analysis is disabled.

    @rryan
    rryan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    1a727d2 View commit details
    Browse the repository at this point in the history

  3. Disable fast analysis when non-constant beatgrids are enabled. 

    We have to analyze the entire song for beats if we are not assuming the detected
BPM applies to the whole track.
    @rryan
    rryan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    d470da1 View commit details
    Browse the repository at this point in the history

  4. Re-implement fast analysis for AnalyzerBeats and AnalyzerKey. 

    Uses a 1-minute cutoff to match the previous implementation.
    @rryan
    rryan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    352d8c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Fix default the beat detector to be the QMUL beat tracker.

    @rryan
    rryan committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    260071e View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. Merge remote-tracking branch 'mixxxdj/master' into remove-vamp

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    19a8ca6 View commit details
    Browse the repository at this point in the history

  2. Move analyzer constants out of analyzerthread.cpp to analyzer/constan… 

    …ts.h.
    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    d4efc86 View commit details
    Browse the repository at this point in the history

  3. Add a constant for the number of seconds to analyze in fast analysis … 

    …mode.
    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ce067ea View commit details
    Browse the repository at this point in the history

  4. Move fast analysis samples calculation to init() and use analyzer/con… 

    …stants.h.
    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2eb5dd5 View commit details
    Browse the repository at this point in the history

  5. Use constants and do not use non-static member initializers.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    254a563 View commit details
    Browse the repository at this point in the history

  6. Use size_t for kWindowSize to be consistent with kStepSize.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    b1e5f12 View commit details
    Browse the repository at this point in the history

  7. Remove VAMP from SConstruct.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    116145a View commit details
    Browse the repository at this point in the history

  8. Remove VAMP from appveyor.yml.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2d17ed4 View commit details
    Browse the repository at this point in the history

  9. Remove logging and unused constant.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    f7afd37 View commit details
    Browse the repository at this point in the history

  10. Remove unused fftw dependency.

    @rryan
    rryan committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    630613f View commit details
    Browse the repository at this point in the history