Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New in 2.3: Add CMake post #80

Merged
merged 11 commits into from
Jul 14, 2020
Merged

New in 2.3: Add CMake post #80

merged 11 commits into from
Jul 14, 2020

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented May 5, 2020

No description provided.

@Holzhaus Holzhaus added the news News posts label May 5, 2020
@Holzhaus Holzhaus mentioned this pull request May 5, 2020
Open
@Holzhaus Holzhaus marked this pull request as draft May 5, 2020 22:05
@daschuer
Copy link
Member

daschuer commented May 5, 2020

Nice, Thank you.

@Be-ing
Copy link
Contributor

Be-ing commented May 6, 2020

You could mention that we especially need help getting CMake builds working on macOS.

@ronso0
Copy link
Member

ronso0 commented May 6, 2020 •
edited
Loading

When I started using cmake I stumbled upon cmake-gui. I consider it to be helpful as it makes the cmake options more discoverable than in the CLI. It's mentioned at cmake.org and that's a tutorial for example.
I think we should at least mention it, but clarify we don't offer support for it.
What do you think?

@Holzhaus
Copy link
Member Author

Holzhaus commented May 6, 2020

I added sentences mentioning cmake-gui and the issues on OSX. Anything else?

@Holzhaus Holzhaus marked this pull request as ready for review May 8, 2020 11:43
@Holzhaus
Copy link
Member Author

Ready to merge.

@Holzhaus Holzhaus requested a review from Be-ing July 14, 2020 21:04
@Be-ing Be-ing merged commit 7960a91 into mixxxdj:website Jul 14, 2020
@Be-ing
Copy link
Contributor

Be-ing commented Jul 14, 2020

Thanks

@ywwg
Copy link
Member

ywwg commented Jul 14, 2020

link on social media?

@Holzhaus
Copy link
Member Author

Yes, but the website builder is down: https://builds.renegadetech.mixxx.org/job/website/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronso0 ronso0 ronso0 left review comments

@Be-ing Be-ing Awaiting requested review from Be-ing

Assignees
No one assigned
Labels
news News posts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Holzhaus @daschuer @Be-ing @ronso0 @ywwg