Don't mess up downloaded content on Windows #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set curl STDIN/OUT to :raw, otherwise the CRLF -> LF conversion will mess up the contents.
|
https://metacpan.org/pod/IPC::Run3#binmode_stdin,-binmode_stdout,-binmode_stderr
|
|
That was quick, thanks!
I just noticed that the wget interface has the same bug. I can create another PR (probably on Sunday), but you're welcome to beat me to it.
…On March 8, 2024 10:48:36 PM GMT+01:00, Tatsuhiko Miyagawa ***@***.***> wrote:
Merged #24 into master.
--
Reply to this email directly or view it on GitHub:
#24 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
yep, feel free to create another PR. Meanwhile I'm having some issues in CI for the SSL cert stuff. |
patrickbkr
added a commit
to Raku/App-Rakubrew
that referenced
this pull request
Mar 12, 2024
PAR doesn't know about DLL dependencies. One needs to explicitly tell it which DLLs to include in the build. Without those DLLs HTTP::Tinyish skipped LWP and HTTP::Tiny because those DLLs were missing for SSL support. It then chose the Curl backend. That contained a bug, which messed up the downloaded content by converting CRLF -> LF. That is now fixed in miyagawa/HTTP-Tinyish#24 We need to explicitly use PAR::Packer 1.057 and not the latest version, because of another bug that causes Dynaloader to fail to find the included DLLs and thus the user observing the same failure mode. See rschupp/PAR-Packer#86
patrickbkr
added a commit
to Raku/App-Rakubrew
that referenced
this pull request
Mar 12, 2024
PAR doesn't know about DLL dependencies. One needs to explicitly tell it which DLLs to include in the build. Without those DLLs HTTP::Tinyish skipped LWP and HTTP::Tiny because those DLLs were missing for SSL support. It then chose the Curl backend. That contained a bug, which messed up the downloaded content by converting CRLF -> LF. That is now fixed in miyagawa/HTTP-Tinyish#24 We need to explicitly use PAR::Packer 1.057 and not the latest version, because of another bug that causes Dynaloader to fail to find the included DLLs and thus the user observing the same failure mode. See rschupp/PAR-Packer#86
patrickbkr
added a commit
to Raku/App-Rakubrew
that referenced
this pull request
Mar 12, 2024
PAR doesn't know about DLL dependencies. One needs to explicitly tell it which DLLs to include in the build. Without those DLLs HTTP::Tinyish skipped LWP and HTTP::Tiny because those DLLs were missing for SSL support. It then chose the Curl backend. That contained a bug, which messed up the downloaded content by converting CRLF -> LF. That is now fixed in miyagawa/HTTP-Tinyish#24 We need to explicitly use PAR::Packer 1.057 and not the latest version, because of another bug that causes Dynaloader to fail to find the included DLLs and thus the user observing the same failure mode. See rschupp/PAR-Packer#86
patrickbkr
added a commit
to Raku/App-Rakubrew
that referenced
this pull request
Mar 12, 2024
PAR doesn't know about DLL dependencies. One needs to explicitly tell it which DLLs to include in the build. Without those DLLs HTTP::Tinyish skipped LWP and HTTP::Tiny because those DLLs were missing for SSL support. It then chose the Curl backend. That contained a bug, which messed up the downloaded content by converting CRLF -> LF. That is now fixed in miyagawa/HTTP-Tinyish#24 We need to explicitly use PAR::Packer 1.057 and not the latest version, because of another bug that causes Dynaloader to fail to find the included DLLs and thus the user observing the same failure mode. See rschupp/PAR-Packer#86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set curl STDIN/OUT to :raw, otherwise the CRLF -> LF conversion will mess up the contents.