JasmineGraph Frontend Shell #254
Conversation
ChandiH
commented
Sep 17, 2024
ChandiH
commented
- implement jasminegraph frontend ui shell ( running in port 7776 )
- seperate common frontend util functions
| @@ -317,182 +308,6 @@ int JasmineGraphFrontEnd::run() { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Why did you delete these code segments?
|
|
||
| for (auto &column : row) { | ||
| switch (counter) { | ||
| case 0: |
There was a problem hiding this comment.
Instead of integers used in the switch can we have some constants/enums?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
=========================================
- Coverage 1.34% 1.28% -0.06%
=========================================
Files 77 79 +2
Lines 15389 15776 +387
Branches 9808 10061 +253
=========================================
- Hits 207 203 -4
- Misses 14978 15372 +394
+ Partials 204 201 -3 ☔ View full report in Codecov by Sentry. |
|
|
@ChandiH Please put a comment for each of the comments resolved explaining how those were resolved. |
…d-out test functions
|
