Re: Move to ESM #85
Closed
Re: Move to ESM #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: drop node z`< 14.3.1`
mizdra
force-pushed
the
use-module-es2020
branch
from
c884ca6
to
3769625
Compare
- enquirer is cjs module - cjs module can always be imported via the default export
mizdra
force-pushed
the
use-module-es2020
branch
from
3769625
to
1802418
Compare
mizdra
force-pushed
the
use-module-es2020
branch
from
1802418
to
c9c97d1
Compare
- Now `src/rule/transform.ts` has been compiled as ESM module - I would like it to compile as CJS module. - So I will enable `module:node12` so that `.cts` can be used
mizdra
force-pushed
the
use-module-es2020
branch
from
0e5caf8
to
ac3470b
Compare
- `jest.requireActual` do not be supported in ESM - So, `test/formatter/index.test.ts` do not work. - I decided to delete this test file since it is not needed in the first place.
mizdra
changed the title
module: es2020 in tsconfig.jsonmodule: node12 in tsconfig.json
mizdra
added
Status: Blocked
|
There's nothing we can do! |
|
Perhaps, we can solve this problem by using eslint/eslint#15453 (comment). Moreover, it can also support eslint v7. |
|
This PR is conflicting, so we need to recreate a new PR. |
mizdra
changed the title
module: node12 in tsconfig.jsonmodule: node12 in tsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #84
blocked: eslint/eslint#15453 OR eslint/eslint#15394
BREAKING CHANGES
< 14.3.1< latest