Add invoke for none javascript lambdas #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This delegates to serverless invoke and then attempts to intelligently parse the lambda response from the output that serverless sends to stdout. Because all logging also goes to stdout, the response parser only looks for json objects and arrays.
Wired up context.success | context.fail methods they will now respond appropriately to the calling server. Also added promise.catch logic to handle lambda failures
brocksamson
changed the title
mj1618
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by how serverless-offline invokes lambdas. I converted the code to typescript, fixed multiple bugs within the serverless-offline implementation and tried to make sure it was well behaved with a few different scenarios.
Additionally I squashed a few other bugs along the way.