Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different entry points in package.json #102

Closed
wants to merge 3 commits into from

Conversation

Dabolus
Copy link

@Dabolus Dabolus commented May 24, 2018

This PR adds the ability to load different entry points by adding the bundle query parameter to a "bare" URL.

The way it works is based on the syntax proposed by @mjackson on #93 (comment)

Note: the usage of the unpkg field as an object in package.json is still undocumented, not sure where the documentation should be added though

Resolves: #93

@mjackson
Copy link
Owner

Thank you for taking a stab at this, @Dabolus. The findFile.js module is a bit of a mess right now, and I'm currently in the middle of a more comprehensive refactoring that will definitely collide with this code. Would you mind if we close for now and revisit when I'm finished? Should be some time early next week.

@Dabolus
Copy link
Author

Dabolus commented Jun 15, 2018

No problem!

@Dabolus Dabolus closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants