You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What do you think of this rule to have a constraint to only be built on the platforms it can actually be built in? I believe wix toolset only works on Windows, at least until wixtoolset/issues#4381
If I use this rule as is, my build will always fail on a non-Windows build agent.
If you agree we need to do this, then we can figure out how to do this, from the documentation: https://docs.bazel.build/versions/master/be/platform.html
Pull requests are welcome, although I don't think target_compatible_with works until bazel 4.0 and I'd prefer to stay compatible with 3.4 for the time being.
In my projects, I construct suitable top level targets for each platform, so instead of doing bazel test //... you do bazel test //:windows
Hi,
I have fixed a hermetic bug in the rules_wix repo. Here is the pull
request: #3 I would like to keep
using the original rules_wix without creating a fork if you can review.
Thanks.
Aditya
On Wed, Nov 25, 2020 at 11:53 AM jpieper ***@***.***> wrote:
Pull requests are welcome, although I don't think target_compatible_with
works until bazel 4.0 and I'd prefer to stay compatible with 3.4 for the
time being.
In my projects, I construct suitable top level targets for each platform,
so instead of doing bazel test //... you do bazel test //:windows
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJMB2VC4H5TZ7EZIQHDHL3SRUZBLANCNFSM4UCLEI2Q>
.
What do you think of this rule to have a constraint to only be built on the platforms it can actually be built in? I believe wix toolset only works on Windows, at least until wixtoolset/issues#4381
rules_wix/rules.bzl
Line 50 in 90b9ccd
If I use this rule as is, my build will always fail on a non-Windows build agent.
If you agree we need to do this, then we can figure out how to do this, from the documentation:
https://docs.bazel.build/versions/master/be/platform.html
I guess in the meanwhile a workaround can be to use a build target constraint with target_compatible_with as in the Bazel documentation https://docs.bazel.build/versions/master/platforms.html#skipping-incompatible-targets
The text was updated successfully, but these errors were encountered: