Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use renderChunk instead of removed transformBundle #211

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

Andarist
Copy link
Contributor

fixes #210

@mjeanroy
Copy link
Owner

mjeanroy commented Jan 8, 2019

Hi @Andarist,

Thanks for your PR (and sorry for the delay, but I was on vacation).

My original plan was to keep compatibility with old versions of rollup (basically < 0.66, not so hard to do by the way), with a warning log and remove this support when I'll release a 1.0.0 version (and since rollup just released a stable 1.0.0 version, I plan to to do it very soon).

But I would be happy to have your opinion about this? Do you think support of old versions of rollup should be removed now?

@Andarist
Copy link
Contributor Author

Andarist commented Jan 8, 2019

Well, i don't know how to detect reliably which version of rollup is used - so not sure how to keep the backwards compatibility.

IMHO with rollup having fairly stable API and having this hook for quire some time before v1 release, I'd say it's not worth much to keep the compatibility anyway - personally I'm in favour of moving faster as rollup updates are really quite easy to do. If somebody is still on older version they can just install compatible version of rollup-plugin-prettier

@mjeanroy mjeanroy merged commit 6bf49cf into mjeanroy:master Jan 16, 2019
@Andarist Andarist deleted the use-render-chunk branch January 17, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reminder]: Some hooks deprecated since Rollup v1.0.0
2 participants