Skip to content

Commit

Permalink
Use IsErrorDocument() to prevent BFCacheing of interstitials and errors.
Browse files Browse the repository at this point in the history
In the bug, a crash occurs because we try to cache an interstitial. We
catch some error documents via status codes etc but interstitials do
not consistently set those. Checking IsErrorDocument() is more reliable.

Bug: 1274308,1287996
Change-Id: Ifec662c169c77e33ca5dc4d56b0e42c8d71f1d97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319862
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981026}
NOKEYCHECK=True
GitOrigin-RevId: 7a05b426c6c51254a08de9a8dee8db9c1911b9c9
  • Loading branch information
fergald authored and copybara-github committed Mar 15, 2022
1 parent 73e65ac commit 1146845
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions blink/public/devtools_protocol/browser_protocol.pdl
Original file line number Diff line number Diff line change
Expand Up @@ -8131,6 +8131,7 @@ domain Page
NoResponseHead
Unknown
ActivationNavigationsDisallowedForBug1234857
ErrorDocument
#Blocklisted features
WebSocket
WebTransport
Expand Down

0 comments on commit 1146845

Please sign in to comment.