Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo in rm4pro device definitions #682

Merged
merged 1 commit into from
May 22, 2022
Merged

Fixing typo in rm4pro device definitions #682

merged 1 commit into from
May 22, 2022

Conversation

nebriv
Copy link

@nebriv nebriv commented May 18, 2022 •
edited
Loading

Swapping comma with colon.

Context

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: fixes #
  • This PR is related to:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@nebriv
Fixing typo in rm4pro device definitions
420edfc 
Swapping comma with colon.
@felipediel felipediel merged commit ed45e96 into mjg59:new_product_ids May 22, 2022
@felipediel
Copy link
Collaborator

Thank you! 👍

@felipediel felipediel added the bug label May 23, 2022
felipediel pushed a commit to felipediel/python-broadlink that referenced this pull request May 23, 2022
@nebriv @felipediel
Fixing typo in rm4pro device definitions (mjg59#682)
0d072ae 
Swapping comma with colon.
@felipediel felipediel mentioned this pull request May 23, 2022
Merged
13 tasks
felipediel added a commit that referenced this pull request May 23, 2022
@felipediel
Merge new product ids into master (#686)
d5cf63b 
* Add support for Broadlink RM4 mini (0x5216) (#671)

* Add support for Broadlink RM4 pro 0x520B (#673)

* Add support for SP4L-UK 0xA569 (#677)

* Fixing typo in rm4pro device definitions (#682)

* Add support for Bestcon RM4C pro (0x5218) (#683)

* Add support for Broadlink RM4 TV mate (0x5212) (#684)

* Add support for Broadlink RM4 mini (0x520C) (#685)
This was referenced May 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebriv @felipediel