Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heating_cooling state to Hysen #722

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Add heating_cooling state to Hysen #722

merged 1 commit into from
Jan 22, 2023

Conversation

fustom
Copy link
Contributor

@fustom fustom commented Nov 14, 2022 •
edited
Loading

Context

Cooling / heating state and switch is missing.

Proposed change

I found the necessary bit to control that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: fixes #
  • This PR is related to:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@felipediel felipediel changed the title Add heating_cooling state Add heating_cooling state to Hysen Jan 22, 2023
@felipediel
Copy link
Collaborator

Awesome! Thank you!

@felipediel felipediel merged commit abcc9aa into mjg59:dev Jan 22, 2023
@fustom fustom deleted the Add_heating_cooling_state2 branch January 26, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fustom @felipediel