Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose durations beyond the CLI #742

Closed
wants to merge 2 commits into from
Closed

Conversation

wgrant
Copy link
Contributor

@wgrant wgrant commented Jan 18, 2023

Context

Broadlink's IR/RF message protocol is well-understood, but translation between it and the standard microsecond duration format usable in other IR contexts is only accessible via broadlink_cli.

Proposed change

Move the two duration<->Broadlink functions from broadlink_cli to broadlink.remote, where they can be used by applications consuming the library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@bengtmartensson
Copy link
Contributor

This is a good idea. However, the implementation conflicts with my PR #741. Either this PR should be rewritten on top of mine, or the other way around.

See also #743.

@felipediel
Copy link
Collaborator

Awesome, I'll merge the fix here.

@felipediel felipediel mentioned this pull request Apr 11, 2024
13 tasks
@felipediel
Copy link
Collaborator

Closed with #788. Thanks @bengtmartensson!

@felipediel felipediel closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants